From 8ed2c8e99fd6f988e272cd2173b10855ce29f3fb Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Thu, 13 Feb 2014 16:48:38 +0000 Subject: [PATCH] Reduce code duplication resulting from the ConstantVector/ConstantDataVector split. No intended functionality change. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@201344 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/CostModel.cpp | 12 ++--------- lib/Transforms/Vectorize/BBVectorize.cpp | 23 +++++++--------------- lib/Transforms/Vectorize/LoopVectorize.cpp | 8 ++------ 3 files changed, 11 insertions(+), 32 deletions(-) diff --git a/lib/Analysis/CostModel.cpp b/lib/Analysis/CostModel.cpp index 898da8d0e8d..8eb5f6857e2 100644 --- a/lib/Analysis/CostModel.cpp +++ b/lib/Analysis/CostModel.cpp @@ -99,17 +99,9 @@ static TargetTransformInfo::OperandValueKind getOperandInfo(Value *V) { TargetTransformInfo::OK_AnyValue; // Check for a splat of a constant or for a non uniform vector of constants. - ConstantDataVector *CDV = 0; - if ((CDV = dyn_cast(V))) { + if (isa(V) || isa(V)) { OpInfo = TargetTransformInfo::OK_NonUniformConstantValue; - if (CDV->getSplatValue() != NULL) - OpInfo = TargetTransformInfo::OK_UniformConstantValue; - } - - ConstantVector *CV = 0; - if ((CV = dyn_cast(V))) { - OpInfo = TargetTransformInfo::OK_NonUniformConstantValue; - if (CV->getSplatValue() != NULL) + if (cast(V)->getSplatValue() != NULL) OpInfo = TargetTransformInfo::OK_UniformConstantValue; } diff --git a/lib/Transforms/Vectorize/BBVectorize.cpp b/lib/Transforms/Vectorize/BBVectorize.cpp index f59dd2160a9..6ef20201306 100644 --- a/lib/Transforms/Vectorize/BBVectorize.cpp +++ b/lib/Transforms/Vectorize/BBVectorize.cpp @@ -1043,22 +1043,13 @@ namespace { // of constants. Value *IOp = I->getOperand(1); Value *JOp = J->getOperand(1); - if (ConstantDataVector *CDVI = dyn_cast(IOp)) { - if (ConstantDataVector *CDVJ = dyn_cast(JOp)) { - Op2VK = TargetTransformInfo::OK_NonUniformConstantValue; - Constant *SplatValue = CDVI->getSplatValue(); - if (SplatValue != NULL && SplatValue == CDVJ->getSplatValue()) - Op2VK = TargetTransformInfo::OK_UniformConstantValue; - } - } - - if (ConstantVector *CVI = dyn_cast(IOp)) { - if (ConstantVector *CVJ = dyn_cast(JOp)) { - Op2VK = TargetTransformInfo::OK_NonUniformConstantValue; - Constant *SplatValue = CVI->getSplatValue(); - if (SplatValue != NULL && SplatValue == CVJ->getSplatValue()) - Op2VK = TargetTransformInfo::OK_UniformConstantValue; - } + if ((isa(IOp) || isa(IOp)) && + (isa(JOp) || isa(JOp))) { + Op2VK = TargetTransformInfo::OK_NonUniformConstantValue; + Constant *SplatValue = cast(IOp)->getSplatValue(); + if (SplatValue != NULL && + SplatValue == cast(JOp)->getSplatValue()) + Op2VK = TargetTransformInfo::OK_UniformConstantValue; } } } diff --git a/lib/Transforms/Vectorize/LoopVectorize.cpp b/lib/Transforms/Vectorize/LoopVectorize.cpp index ecbab63acf0..d7d66e79161 100644 --- a/lib/Transforms/Vectorize/LoopVectorize.cpp +++ b/lib/Transforms/Vectorize/LoopVectorize.cpp @@ -5496,13 +5496,9 @@ LoopVectorizationCostModel::getInstructionCost(Instruction *I, unsigned VF) { // Check for a splat of a constant or for a non uniform vector of constants. if (isa(Op2)) Op2VK = TargetTransformInfo::OK_UniformConstantValue; - else if (ConstantDataVector *CDV = dyn_cast(Op2)) { + else if (isa(Op2) || isa(Op2)) { Op2VK = TargetTransformInfo::OK_NonUniformConstantValue; - if (CDV->getSplatValue() != NULL) - Op2VK = TargetTransformInfo::OK_UniformConstantValue; - } else if (ConstantVector *CV = dyn_cast(Op2)) { - Op2VK = TargetTransformInfo::OK_NonUniformConstantValue; - if (CV->getSplatValue() != NULL) + if (cast(Op2)->getSplatValue() != NULL) Op2VK = TargetTransformInfo::OK_UniformConstantValue; }