From 90fdf9c6debbdcc61076a1e020c3dff4dc71d838 Mon Sep 17 00:00:00 2001
From: Reid Spencer <rspencer@reidspencer.com>
Date: Mon, 4 Dec 2006 21:34:17 +0000
Subject: [PATCH] Separate the get and getTy functions for ICmp and FCmp into
getCompare and getCompareTy. Also, fix some incorrect comments.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@32199 91177308-0d34-0410-b5e6-96231b3b80d8
---
include/llvm/Constants.h | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/include/llvm/Constants.h b/include/llvm/Constants.h
index 47255de655b..93be8bf06f9 100644
--- a/include/llvm/Constants.h
+++ b/include/llvm/Constants.h
@@ -498,7 +498,9 @@ protected:
// These private methods are used by the type resolution code to create
// ConstantExprs in intermediate forms.
static Constant *getTy(const Type *Ty, unsigned Opcode,
- Constant *C1, Constant *C2, unsigned short pred = 0);
+ Constant *C1, Constant *C2);
+ static Constant *getCompareTy(unsigned Opcode, unsigned short pred,
+ Constant *C1, Constant *C2);
static Constant *getShiftTy(const Type *Ty,
unsigned Opcode, Constant *C1, Constant *C2);
static Constant *getSelectTy(const Type *Ty,
@@ -549,14 +551,14 @@ public:
// @brief Create a SExt or BitCast cast constant expression
static Constant *getSExtOrBitCast(
- Constant *C, ///< The constant to zext or bitcast
- const Type *Ty ///< The type to zext or bitcast C to
+ Constant *C, ///< The constant to sext or bitcast
+ const Type *Ty ///< The type to sext or bitcast C to
);
// @brief Create a Trunc or BitCast cast constant expression
static Constant *getTruncOrBitCast(
- Constant *C, ///< The constant to zext or bitcast
- const Type *Ty ///< The type to zext or bitcast C to
+ Constant *C, ///< The constant to trunc or bitcast
+ const Type *Ty ///< The type to trunc or bitcast C to
);
// This method uses the CastInst::getCastOpcode method to infer the
@@ -593,8 +595,11 @@ public:
/// ConstantExpr::get - Return a binary or shift operator constant expression,
/// folding if possible.
///
- static Constant *get(unsigned Opcode, Constant *C1, Constant *C2,
- unsigned short pred = 0);
+ static Constant *get(unsigned Opcode, Constant *C1, Constant *C2);
+
+ /// @brief Return an ICmp or FCmp comparison operator constante expression.
+ static Constant *getCompare(unsigned Opcode, unsigned short pred,
+ Constant *C1, Constant *C2);
/// ConstantExpr::get* - Return some common constants without having to
/// specify the full Instruction::OPCODE identifier.