From 91bb61a1e2c96f727726c2fe7962df3e18ef5416 Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Tue, 26 May 2009 17:44:05 +0000 Subject: [PATCH] For the return type of SCEVUDivExpr, use the RHS' type instead of that of the LHS. It doesn't matter for correctness, but the LHS is more likely than the RHS to be a pointer type in exotic cases, and it's more tidy to have it return the integer type. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@72424 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/ScalarEvolution.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/Analysis/ScalarEvolution.cpp b/lib/Analysis/ScalarEvolution.cpp index b150db30c20..f7f1849b6da 100644 --- a/lib/Analysis/ScalarEvolution.cpp +++ b/lib/Analysis/ScalarEvolution.cpp @@ -346,7 +346,12 @@ void SCEVUDivExpr::print(raw_ostream &OS) const { } const Type *SCEVUDivExpr::getType() const { - return LHS->getType(); + // In most cases the types of LHS and RHS will be the same, but in some + // crazy cases one or the other may be a pointer. ScalarEvolution doesn't + // depend on the type for correctness, but handling types carefully can + // avoid extra casts in the SCEVExpander. The LHS is more likely to be + // a pointer type than the RHS, so use the RHS' type here. + return RHS->getType(); } // SCEVAddRecExprs - Only allow the creation of one SCEVAddRecExpr for any