Add support for arbitrary functors to CrashRecoveryContext.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202895 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Richard Smith 2014-03-04 21:48:49 +00:00
parent f0a0ceb034
commit 943d1fdffe
2 changed files with 19 additions and 6 deletions

View File

@ -10,6 +10,7 @@
#ifndef LLVM_SUPPORT_CRASHRECOVERYCONTEXT_H #ifndef LLVM_SUPPORT_CRASHRECOVERYCONTEXT_H
#define LLVM_SUPPORT_CRASHRECOVERYCONTEXT_H #define LLVM_SUPPORT_CRASHRECOVERYCONTEXT_H
#include <functional>
#include <string> #include <string>
namespace llvm { namespace llvm {
@ -75,6 +76,7 @@ public:
/// make as little assumptions as possible about the program state when /// make as little assumptions as possible about the program state when
/// RunSafely has returned false. Clients can use getBacktrace() to retrieve /// RunSafely has returned false. Clients can use getBacktrace() to retrieve
/// the backtrace of the crash on failures. /// the backtrace of the crash on failures.
bool RunSafely(std::function<void()> Fn);
bool RunSafely(void (*Fn)(void*), void *UserData); bool RunSafely(void (*Fn)(void*), void *UserData);
/// \brief Execute the provide callback function (with the given arguments) in /// \brief Execute the provide callback function (with the given arguments) in
@ -84,6 +86,8 @@ public:
/// See RunSafely() and llvm_execute_on_thread(). /// See RunSafely() and llvm_execute_on_thread().
bool RunSafelyOnThread(void (*Fn)(void*), void *UserData, bool RunSafelyOnThread(void (*Fn)(void*), void *UserData,
unsigned RequestedStackSize = 0); unsigned RequestedStackSize = 0);
bool RunSafelyOnThread(std::function<void()> Fn,
unsigned RequestedStackSize = 0);
/// \brief Explicitly trigger a crash recovery in the current process, and /// \brief Explicitly trigger a crash recovery in the current process, and
/// return failure from RunSafely(). This function does not return. /// return failure from RunSafely(). This function does not return.

View File

@ -302,6 +302,10 @@ void CrashRecoveryContext::Disable() {
#endif #endif
bool CrashRecoveryContext::RunSafely(void (*Fn)(void*), void *UserData) { bool CrashRecoveryContext::RunSafely(void (*Fn)(void*), void *UserData) {
return RunSafely([&]() { Fn(UserData); });
}
bool CrashRecoveryContext::RunSafely(std::function<void()> Fn) {
// If crash recovery is disabled, do nothing. // If crash recovery is disabled, do nothing.
if (gCrashRecoveryEnabled) { if (gCrashRecoveryEnabled) {
assert(!Impl && "Crash recovery context already initialized!"); assert(!Impl && "Crash recovery context already initialized!");
@ -313,7 +317,7 @@ bool CrashRecoveryContext::RunSafely(void (*Fn)(void*), void *UserData) {
} }
} }
Fn(UserData); Fn();
return true; return true;
} }
@ -332,10 +336,14 @@ const std::string &CrashRecoveryContext::getBacktrace() const {
// //
bool CrashRecoveryContext::RunSafelyOnThread(void (*Fn)(void*), void *UserData,
unsigned RequestedStackSize) {
return RunSafelyOnThread([&]() { Fn(UserData); }, RequestedStackSize);
}
namespace { namespace {
struct RunSafelyOnThreadInfo { struct RunSafelyOnThreadInfo {
void (*UserFn)(void*); std::function<void()> Fn;
void *UserData;
CrashRecoveryContext *CRC; CrashRecoveryContext *CRC;
bool Result; bool Result;
}; };
@ -344,11 +352,12 @@ struct RunSafelyOnThreadInfo {
static void RunSafelyOnThread_Dispatch(void *UserData) { static void RunSafelyOnThread_Dispatch(void *UserData) {
RunSafelyOnThreadInfo *Info = RunSafelyOnThreadInfo *Info =
reinterpret_cast<RunSafelyOnThreadInfo*>(UserData); reinterpret_cast<RunSafelyOnThreadInfo*>(UserData);
Info->Result = Info->CRC->RunSafely(Info->UserFn, Info->UserData); Info->Result = Info->CRC->RunSafely(Info->Fn);
} }
bool CrashRecoveryContext::RunSafelyOnThread(void (*Fn)(void*), void *UserData,
bool CrashRecoveryContext::RunSafelyOnThread(std::function<void()> Fn,
unsigned RequestedStackSize) { unsigned RequestedStackSize) {
RunSafelyOnThreadInfo Info = { Fn, UserData, this, false }; RunSafelyOnThreadInfo Info = { Fn, this, false };
llvm_execute_on_thread(RunSafelyOnThread_Dispatch, &Info, RequestedStackSize); llvm_execute_on_thread(RunSafelyOnThread_Dispatch, &Info, RequestedStackSize);
if (CrashRecoveryContextImpl *CRC = (CrashRecoveryContextImpl *)Impl) if (CrashRecoveryContextImpl *CRC = (CrashRecoveryContextImpl *)Impl)
CRC->setSwitchedThread(); CRC->setSwitchedThread();