6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-05 13:26:55 +00:00
Code Issues Projects Releases Wiki Activity

If errno is zero strerror_r does not modify the buffer, leaving it unterminated.

Browse Source 
This causes garbage to be printed out after error messages.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@20165 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner
2005-02-13 22:46:37 +00:00
parent 2e12c745ea
commit 946af52687
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/System/Unix/MappedFile.inc
View File

@@ -51,6 +51,7 @@ void MappedFile::initialize() {
else if (options_&WRITE_ACCESS)
mode = O_WRONLY;
info_->fd_ = ::open(path_.c_str(),mode);
if (info_->fd_ < 0) {
delete info_;
info_ = 0;

7
lib/System/Unix/Unix.h
View File

@@ -68,14 +68,17 @@
inline void ThrowErrno(const std::string& prefix) {
char buffer[MAXPATHLEN];
buffer[0] = 0;
#ifdef HAVE_STRERROR_R
// strerror_r is thread-safe.
strerror_r(errno,buffer,MAXPATHLEN-1);
if (errno)
strerror_r(errno,buffer,MAXPATHLEN-1);
#elif HAVE_STRERROR
// Copy the thread un-safe result of strerror into
// the buffer as fast as possible to minimize impact
// of collision of strerror in multiple threads.
strncpy(buffer,strerror(errno),MAXPATHLEN-1);
if (Errno)
strncpy(buffer,strerror(errno),MAXPATHLEN-1);
buffer[MAXPATHLEN-1] = 0;
#else
// Strange that this system doesn't even have strerror