Undo the hack in r147427 and move this unittest to a better home. This

is testing the bitcode reader's functionality, not VMCore's. Add the
what is a hope sufficient build system mojo to build and run a new
unittest.

Also clean up some of the test's naming. The goal for the file should be
to unittest the Bitcode Reader, and this is just one particular test
among potentially many in the future. Also, reverse my position and
relegate the PR# to a comment, but stash the comment on the same line as
the test name so it doesn't get lost. This makes the code more
self-documenting hopefully w/o losing track of the PR number.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@147431 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chandler Carruth 2012-01-02 09:19:48 +00:00
parent c612d79817
commit 972cc0d54a
5 changed files with 24 additions and 5 deletions

View File

@ -1,4 +1,4 @@
//===- llvm/unittest/VMCore/pr11677.cpp - Test for blockaddr --------------===// //===- llvm/unittest/Bitcode/BitReaderTest.cpp - Tests for BitReader ------===//
// //
// The LLVM Compiler Infrastructure // The LLVM Compiler Infrastructure
// //
@ -49,7 +49,7 @@ static void writeModuleToBuffer(std::vector<unsigned char> &Buffer) {
WriteBitcodeToStream(Mod, Stream); WriteBitcodeToStream(Mod, Stream);
} }
TEST(PR11677, BlockAddr) { TEST(BitReaderTest, MaterializeFunctionsForBlockAddr) { // PR11677
std::vector<unsigned char> Mem; std::vector<unsigned char> Mem;
writeModuleToBuffer(Mem); writeModuleToBuffer(Mem);
StringRef Data((const char*)&Mem[0], Mem.size()); StringRef Data((const char*)&Mem[0], Mem.size());
@ -60,5 +60,6 @@ TEST(PR11677, BlockAddr) {
passes.add(createVerifierPass()); passes.add(createVerifierPass());
passes.run(*m); passes.run(*m);
} }
} }
} }

View File

@ -0,0 +1,15 @@
##===- unittests/Bitcode/Makefile --------------------------*- Makefile -*-===##
#
# The LLVM Compiler Infrastructure
#
# This file is distributed under the University of Illinois Open Source
# License. See LICENSE.TXT for details.
#
##===----------------------------------------------------------------------===##
LEVEL = ../..
TESTNAME = Bitcode
LINK_COMPONENTS := core support bitreader bitwriter
include $(LEVEL)/Makefile.config
include $(LLVM_SRC_ROOT)/unittests/Makefile.unittest

View File

@ -112,7 +112,6 @@ set(VMCoreSources
VMCore/PassManagerTest.cpp VMCore/PassManagerTest.cpp
VMCore/ValueMapTest.cpp VMCore/ValueMapTest.cpp
VMCore/VerifierTest.cpp VMCore/VerifierTest.cpp
VMCore/pr11677.cpp
) )
# MSVC9 and 8 cannot compile ValueMapTest.cpp due to their bug. # MSVC9 and 8 cannot compile ValueMapTest.cpp due to their bug.
@ -123,6 +122,10 @@ endif()
add_llvm_unittest(VMCore ${VMCoreSources}) add_llvm_unittest(VMCore ${VMCoreSources})
add_llvm_unittest(Bitcode
Bitcode/BitReaderTest.cpp
)
set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
Core Core

View File

@ -9,7 +9,7 @@
LEVEL = .. LEVEL = ..
PARALLEL_DIRS = ADT ExecutionEngine Support Transforms VMCore Analysis PARALLEL_DIRS = ADT ExecutionEngine Support Transforms VMCore Analysis Bitcode
include $(LEVEL)/Makefile.common include $(LEVEL)/Makefile.common

View File

@ -9,7 +9,7 @@
LEVEL = ../.. LEVEL = ../..
TESTNAME = VMCore TESTNAME = VMCore
LINK_COMPONENTS := core support bitreader bitwriter target ipa LINK_COMPONENTS := core support target ipa
include $(LEVEL)/Makefile.config include $(LEVEL)/Makefile.config
include $(LLVM_SRC_ROOT)/unittests/Makefile.unittest include $(LLVM_SRC_ROOT)/unittests/Makefile.unittest