From 9a05b98ef9ec58c52f35ce04677f24ef62a79701 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Mon, 22 Jul 2013 19:30:38 +0000 Subject: [PATCH] [mips] Fix MipsAsmParser::parseCCRRegs. Enable parsing all 32 floating point control registers $0-31 and stop trying to parse floating point condition code register $fcc0. Also, return ParseFail if the operand being parsed is not in the expected format. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@186861 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/Mips/AsmParser/MipsAsmParser.cpp | 27 ++++++++------------- test/MC/Mips/mips-fpu-instructions.s | 4 ++- 2 files changed, 13 insertions(+), 18 deletions(-) diff --git a/lib/Target/Mips/AsmParser/MipsAsmParser.cpp b/lib/Target/Mips/AsmParser/MipsAsmParser.cpp index 56a5dfdafbd..3e9b950494c 100644 --- a/lib/Target/Mips/AsmParser/MipsAsmParser.cpp +++ b/lib/Target/Mips/AsmParser/MipsAsmParser.cpp @@ -1449,30 +1449,23 @@ MipsAsmParser::parseHW64Regs( MipsAsmParser::OperandMatchResultTy MipsAsmParser::parseCCRRegs(SmallVectorImpl &Operands) { - unsigned RegNum; // If the first token is not '$' we have an error. if (Parser.getTok().isNot(AsmToken::Dollar)) - return MatchOperand_NoMatch; + return MatchOperand_ParseFail; + SMLoc S = Parser.getTok().getLoc(); Parser.Lex(); // Eat the '$' const AsmToken &Tok = Parser.getTok(); // Get next token. - if (Tok.is(AsmToken::Integer)) { - RegNum = Tok.getIntVal(); - // At the moment only fcc0 is supported. - if (RegNum != 0) - return MatchOperand_ParseFail; - } else if (Tok.is(AsmToken::Identifier)) { - // At the moment only fcc0 is supported. - if (Tok.getIdentifier() != "fcc0") - return MatchOperand_ParseFail; - } else - return MatchOperand_NoMatch; - MipsOperand *op = MipsOperand::CreateReg(Mips::FCC0, S, - Parser.getTok().getLoc()); - op->setRegKind(MipsOperand::Kind_CCRRegs); - Operands.push_back(op); + if (Tok.isNot(AsmToken::Integer)) + return MatchOperand_ParseFail; + + unsigned Reg = matchRegisterByNumber(Tok.getIntVal(), Mips::CCRRegClassID); + + MipsOperand *Op = MipsOperand::CreateReg(Reg, S, Parser.getTok().getLoc()); + Op->setRegKind(MipsOperand::Kind_CCRRegs); + Operands.push_back(Op); Parser.Lex(); // Eat the register number. return MatchOperand_Success; diff --git a/test/MC/Mips/mips-fpu-instructions.s b/test/MC/Mips/mips-fpu-instructions.s index 5ff31f3e493..256ce4513b7 100644 --- a/test/MC/Mips/mips-fpu-instructions.s +++ b/test/MC/Mips/mips-fpu-instructions.s @@ -138,7 +138,8 @@ # FP move instructions #------------------------------------------------------------------------------ -# CHECK: cfc1 $6, $fcc0 # encoding: [0x00,0x00,0x46,0x44] +# CHECK: cfc1 $6, $0 # encoding: [0x00,0x00,0x46,0x44] +# CHECK: ctc1 $10, $31 # encoding: [0x00,0xf8,0xca,0x44] # CHECK: mfc1 $6, $f7 # encoding: [0x00,0x38,0x06,0x44] # CHECK: mfhi $5 # encoding: [0x10,0x28,0x00,0x00] # CHECK: mflo $5 # encoding: [0x12,0x28,0x00,0x00] @@ -162,6 +163,7 @@ # CHECK: suxc1 $f4, $24($5) # encoding: [0x0d,0x20,0xb8,0x4c] cfc1 $a2,$0 + ctc1 $10,$31 mfc1 $a2,$f7 mfhi $a1 mflo $a1