diff --git a/lib/Support/SystemUtils.cpp b/lib/Support/SystemUtils.cpp index c8c323876bf..c86e200fd95 100644 --- a/lib/Support/SystemUtils.cpp +++ b/lib/Support/SystemUtils.cpp @@ -51,7 +51,7 @@ sys::Path llvm::FindExecutable(const std::string &ExeName, // Otherwise check the directory that the calling program is in. We can do // this if ProgramPath contains at least one / character, indicating that it - // is a relative path to bugpoint itself. + // is a relative path to the executable itself. Result = ProgramPath; Result.eraseComponent(); if (!Result.isEmpty()) { diff --git a/lib/System/Path.cpp b/lib/System/Path.cpp index 72bd7ad6f04..ce4762e56d8 100644 --- a/lib/System/Path.cpp +++ b/lib/System/Path.cpp @@ -13,6 +13,7 @@ #include "llvm/System/Path.h" #include "llvm/Config/config.h" +#include "llvm/Support/ErrorHandling.h" #include #include #include @@ -207,18 +208,6 @@ bool Path::hasMagicNumber(const std::string &Magic) const { return false; } -void Path::makeAbsolute() { - if (isAbsolute()) - return; - - Path CWD = Path::GetCurrentDirectory(); - assert(CWD.isAbsolute() && "GetCurrentDirectory returned relative path!"); - - CWD.appendComponent(path); - - path = CWD.toString(); -} - static void getPathList(const char*path, std::vector& Paths) { const char* at = path; const char* delim = strchr(at, PathSeparator); diff --git a/lib/System/Unix/Path.inc b/lib/System/Unix/Path.inc index 125a0ab209c..e951fa03557 100644 --- a/lib/System/Unix/Path.inc +++ b/lib/System/Unix/Path.inc @@ -109,6 +109,19 @@ Path::isAbsolute() const { return false; return path[0] == '/'; } + +void Path::makeAbsolute() { + if (isAbsolute()) + return; + + Path CWD = Path::GetCurrentDirectory(); + assert(CWD.isAbsolute() && "GetCurrentDirectory returned relative path!"); + + CWD.appendComponent(path); + + path = CWD.toString(); +} + Path Path::GetRootDirectory() { Path result; diff --git a/lib/System/Win32/Path.inc b/lib/System/Win32/Path.inc index 683c94bba44..dac1d1dafb5 100644 --- a/lib/System/Win32/Path.inc +++ b/lib/System/Win32/Path.inc @@ -125,9 +125,30 @@ Path::isValid() const { return true; } +void Path::makeAbsolute() { + TCHAR FullPath[MAX_PATH + 1] = {0}; + LPTSTR FilePart = NULL; + + DWORD RetLength = ::GetFullPathNameA(path.c_str(), + sizeof(FullPath)/sizeof(FullPath[0]), + FullPath, &FilePart); + + if (0 == RetLength) { + // FIXME: Report the error GetLastError() + llvm_unreachable("Unable to make absolute path!"); + } else if (RetLength > MAX_PATH) { + // FIXME: Report too small buffer (needed RetLength bytes). + llvm_unreachable("Unable to make absolute path!"); + } else { + path = FullPath; + } +} + bool Path::isAbsolute(const char *NameStart, unsigned NameLen) { assert(NameStart); + // FIXME: This does not handle correctly an absolute path starting from + // a drive letter or in UNC format. switch (NameLen) { case 0: return false; @@ -141,6 +162,8 @@ Path::isAbsolute(const char *NameStart, unsigned NameLen) { bool Path::isAbsolute() const { + // FIXME: This does not handle correctly an absolute path starting from + // a drive letter or in UNC format. switch (path.length()) { case 0: return false;