6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-15 04:30:12 +00:00
Code Issues Projects Releases Wiki Activity

ValueTracking: Make isBytewiseValue simpler and more powerful at the same time.

Browse Source 
Turns out there is a simpler way of checking that all bytes in a word are equal
than binary decomposition.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@228503 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Benjamin Kramer 2015-02-07 19:29:02 +00:00
parent 2dd5f23a1d
commit a54b82a9fe
2 changed files with 23 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lib/Analysis/ValueTracking.cpp
View File

@ -2121,26 +2121,16 @@ Value *llvm::isBytewiseValue(Value *V) {
// Don't handle long double formats, which have strange constraints. // Don't handle long double formats, which have strange constraints.
} }
// We can handle constant integers that are power of two in size and a // We can handle constant integers that are multiple of 8 bits.
// multiple of 8 bits.
if (ConstantInt *CI = dyn_cast<ConstantInt>(V)) { if (ConstantInt *CI = dyn_cast<ConstantInt>(V)) {
unsigned Width = CI->getBitWidth(); if (CI->getBitWidth() % 8 == 0) {
if (isPowerOf2_32(Width) && Width > 8) { assert(CI->getBitWidth() > 8 && "8 bits should be handled above!");
// We can handle this value if the recursive binary decomposition is the
// same at all levels.
APInt Val = CI->getValue();
APInt Val2;
while (Val.getBitWidth() != 8) {
unsigned NextWidth = Val.getBitWidth()/2;
Val2 = Val.lshr(NextWidth);
Val2 = Val2.trunc(Val.getBitWidth()/2);
Val = Val.trunc(Val.getBitWidth()/2);
// If the top/bottom halves aren't the same, reject it. // We can check that all bytes of an integer are equal by making use of a
if (Val != Val2) // little trick: rotate by 8 and check if it's still the same value.
if (CI->getValue() != CI->getValue().rotl(8))
return nullptr; return nullptr;
} return ConstantInt::get(V->getContext(), CI->getValue().trunc(8));
return ConstantInt::get(V->getContext(), Val);
} }
} }

15
test/Transforms/MemCpyOpt/form-memset.ll
View File

@ -284,3 +284,18 @@ define void @test10(i8* nocapture %P) nounwind {
; CHECK-NOT: memset ; CHECK-NOT: memset
; CHECK: ret void ; CHECK: ret void
} }
; Memset followed by odd store.
define void @test11(i32* nocapture %P) nounwind ssp {
entry:
%add.ptr = getelementptr inbounds i32* %P, i64 3
%0 = bitcast i32* %add.ptr to i8*
tail call void @llvm.memset.p0i8.i64(i8* %0, i8 1, i64 11, i32 1, i1 false)
%arrayidx = getelementptr inbounds i32* %P, i64 0
%arrayidx.cast = bitcast i32* %arrayidx to i96*
store i96 310698676526526814092329217, i96* %arrayidx.cast, align 4
ret void
; CHECK-LABEL: @test11(
; CHECK-NOT: store
; CHECK: call void @llvm.memset.p0i8.i64(i8* %1, i8 1, i64 23, i32 4, i1 false)
}