6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-14 11:32:34 +00:00
Code Issues Projects Releases Wiki Activity

Make sure that we don't call getZExtValue on values > 64 bits.

Browse Source 
Thanks Benjamin for noticing this.



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@162749 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Nadav Rotem 2012-08-28 12:23:22 +00:00
parent 9753f0b9b4
commit a694e2a691
2 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
View File

@ -462,11 +462,11 @@ Instruction *InstCombiner::visitUDiv(BinaryOperator &I) {
} }
} }
// Udiv ((Lshl x, c1) , c2) -> x / (C1 * 1<<C2); // Udiv ((Lshl x, C1) , C2) -> x / (C2 * 1<<C1);
if (Constant *C = dyn_cast<Constant>(Op1)) { if (ConstantInt *C2 = dyn_cast<ConstantInt>(Op1)) {
Value *X = 0, *C1 = 0; Value *X = 0, *C1 = 0;
if (match(Op0, m_LShr(m_Value(X), m_Value(C1)))) { if (match(Op0, m_LShr(m_Value(X), m_Value(C1))) && C2->getBitWidth() < 65) {
uint64_t NC = cast<ConstantInt>(C)->getZExtValue() * uint64_t NC = cast<ConstantInt>(C2)->getZExtValue() *
(1<< cast<ConstantInt>(C1)->getZExtValue()); (1<< cast<ConstantInt>(C1)->getZExtValue());
return BinaryOperator::CreateUDiv(X, ConstantInt::get(I.getType(), NC)); return BinaryOperator::CreateUDiv(X, ConstantInt::get(I.getType(), NC));
} }
@ -543,11 +543,11 @@ Instruction *InstCombiner::visitSDiv(BinaryOperator &I) {
ConstantExpr::getNeg(RHS)); ConstantExpr::getNeg(RHS));
} }
// Sdiv ((Ashl x, c1) , c2) -> x / (C1 * 1<<C2); // Sdiv ((Ashl x, C1) , C2) -> x / (C2 * 1<<C1);
if (Constant *C = dyn_cast<Constant>(Op1)) { if (ConstantInt *C2 = dyn_cast<ConstantInt>(Op1)) {
Value *X = 0, *C1 = 0; Value *X = 0, *C1 = 0;
if (match(Op0, m_AShr(m_Value(X), m_Value(C1)))) { if (match(Op0, m_AShr(m_Value(X), m_Value(C1))) && C2->getBitWidth() < 65) {
uint64_t NC = cast<ConstantInt>(C)->getZExtValue() * uint64_t NC = cast<ConstantInt>(C2)->getZExtValue() *
(1<< cast<ConstantInt>(C1)->getZExtValue()); (1<< cast<ConstantInt>(C1)->getZExtValue());
return BinaryOperator::CreateSDiv(X, ConstantInt::get(I.getType(), NC)); return BinaryOperator::CreateSDiv(X, ConstantInt::get(I.getType(), NC));
} }

7
test/Transforms/InstCombine/2012-08-28-udiv_ashl.ll
View File

@ -48,3 +48,10 @@ entry:
%div1 = sdiv i32 %div, 100 %div1 = sdiv i32 %div, 100
ret i32 %div1 ret i32 %div1
} }
define i80 @no_crash_i80(i80 %x) {
entry:
%div = lshr i80 %x, 2
%div1 = udiv i80 %div, 100
ret i80 %div1
}