6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-21 18:24:23 +00:00
Code Issues Projects Releases Wiki Activity

Fix i386 relocations to Weak Definitions. The relocation entries should be

Browse Source 
external and the item to be relocated should not have the address of the
symbol added in.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@103302 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Kevin Enderby
2010-05-07 21:44:23 +00:00
parent 62077af40e
commit a6eeb6e226
4 changed files with 113 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/MC/MachObjectWriter.cpp
View File

@ -16,6 +16,7 @@
#include "llvm/MC/MCObjectWriter.h"
#include "llvm/MC/MCSectionMachO.h"
#include "llvm/MC/MCSymbol.h"
#include "llvm/MC/MCMachOSymbolFlags.h"
#include "llvm/MC/MCValue.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/MachO.h"
@ -753,9 +754,19 @@ public:
const MCSymbol *Symbol = &Target.getSymA()->getSymbol();
MCSymbolData *SD = &Asm.getSymbolData(*Symbol);
if (Symbol->isUndefined()) {
// Both references to undefined symbols and references to Weak Definitions
// get external relocation entries. This is so the static and then the
// the dynamic linker can resolve them to the actual definition that will
// be used. And in the case of Weak Definitions a reference to one will
// not always be to the definition in the same object file.
if (Symbol->isUndefined() || (SD->getFlags() & SF_WeakDefinition)) {
IsExtern = 1;
Index = SD->getIndex();
// In the case of a Weak Definition the FixedValue needs to be set to
// to not have the address of the symbol. In the case of an undefined
// symbol you can't call getSymbolAddress().
if (SD->getFlags() & SF_WeakDefinition)
FixedValue -= Layout.getSymbolAddress(SD);
Value = 0;
} else {
// The index is the section ordinal (1-based).