Rename functions to something more descriptive. At the very least mention the

CIE and FDE in their names.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@79969 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Bill Wendling 2009-08-25 02:27:42 +00:00
parent 5fee49eff9
commit a6f91da8b2
2 changed files with 18 additions and 13 deletions

View File

@ -49,8 +49,11 @@ DwarfException::~DwarfException() {
delete ExceptionTimer; delete ExceptionTimer;
} }
void DwarfException::EmitCommonEHFrame(const Function *Personality, /// EmitCommonInformationEntry - Emit a Common Information Entry (CIE). This
unsigned Index) { /// holds information that is shared among many Frame Description Entries.
/// There is at least one CIE in every non-empty .debug_frame section.
void DwarfException::EmitCommonInformationEntry(const Function *Personality,
unsigned Index) {
// Size and sign of stack growth. // Size and sign of stack growth.
int stackGrowth = int stackGrowth =
Asm->TM.getFrameInfo()->getStackGrowthDirection() == Asm->TM.getFrameInfo()->getStackGrowthDirection() ==
@ -144,9 +147,10 @@ void DwarfException::EmitCommonEHFrame(const Function *Personality,
Asm->EOL(); Asm->EOL();
} }
/// EmitEHFrame - Emit function exception frame information. /// EmitFrameDescriptionEntry - Emit the Frame Description Entry (FDE) for the
/// /// function.
void DwarfException::EmitEHFrame(const FunctionEHFrameInfo &EHFrameInfo) { void DwarfException::
EmitFrameDescriptionEntry(const FunctionEHFrameInfo &EHFrameInfo) {
assert(!EHFrameInfo.function->hasAvailableExternallyLinkage() && assert(!EHFrameInfo.function->hasAvailableExternallyLinkage() &&
"Should not emit 'available externally' functions at all"); "Should not emit 'available externally' functions at all");
@ -844,11 +848,11 @@ void DwarfException::EndModule() {
if (shouldEmitMovesModule || shouldEmitTableModule) { if (shouldEmitMovesModule || shouldEmitTableModule) {
const std::vector<Function *> Personalities = MMI->getPersonalities(); const std::vector<Function *> Personalities = MMI->getPersonalities();
for (unsigned i = 0; i < Personalities.size(); ++i) for (unsigned i = 0; i < Personalities.size(); ++i)
EmitCommonEHFrame(Personalities[i], i); EmitCommonInformationEntry(Personalities[i], i);
for (std::vector<FunctionEHFrameInfo>::iterator I = EHFrames.begin(), for (std::vector<FunctionEHFrameInfo>::iterator I = EHFrames.begin(),
E = EHFrames.end(); I != E; ++I) E = EHFrames.end(); I != E; ++I)
EmitEHFrame(*I); EmitFrameDescriptionEntry(*I);
} }
if (TimePassesIsEnabled) if (TimePassesIsEnabled)

View File

@ -70,13 +70,14 @@ class VISIBILITY_HIDDEN DwarfException : public Dwarf {
/// ExceptionTimer - Timer for the Dwarf exception writer. /// ExceptionTimer - Timer for the Dwarf exception writer.
Timer *ExceptionTimer; Timer *ExceptionTimer;
/// EmitCommonEHFrame - Emit the common eh unwind frame. /// EmitCommonInformationEntry - Emit a Common Information Entry (CIE). This
/// /// holds information that is shared among many Frame Description Entries.
void EmitCommonEHFrame(const Function *Personality, unsigned Index); /// There is at least one CIE in every non-empty .debug_frame section.
void EmitCommonInformationEntry(const Function *Personality, unsigned Index);
/// EmitEHFrame - Emit function exception frame information. /// EmitFrameDescriptionEntry - Emit the Frame Description Entry (FDE) for the
/// /// function.
void EmitEHFrame(const FunctionEHFrameInfo &EHFrameInfo); void EmitFrameDescriptionEntry(const FunctionEHFrameInfo &EHFrameInfo);
/// EmitExceptionTable - Emit landing pads and actions. /// EmitExceptionTable - Emit landing pads and actions.
/// ///