fix the quotient returned by sdivrem() for the case when LHS is negative and RHS is positive

based on a patch by Preston Briggs, with some modifications

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@157231 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Nuno Lopes 2012-05-22 01:09:48 +00:00
parent 6b07bc604e
commit a7a2a3635f
2 changed files with 31 additions and 2 deletions

View File

@ -817,9 +817,10 @@ public:
if (LHS.isNegative()) {
if (RHS.isNegative())
APInt::udivrem(-LHS, -RHS, Quotient, Remainder);
else
else {
APInt::udivrem(-LHS, RHS, Quotient, Remainder);
Quotient = -Quotient;
Quotient = -Quotient;
}
Remainder = -Remainder;
} else if (RHS.isNegative()) {
APInt::udivrem(LHS, -RHS, Quotient, Remainder);

View File

@ -171,6 +171,34 @@ TEST(APIntTest, i1) {
EXPECT_EQ(zero, neg_one.srem(one));
EXPECT_EQ(zero, neg_one.urem(one));
EXPECT_EQ(zero, one.srem(neg_one));
// sdivrem
{
APInt q(8, 0);
APInt r(8, 0);
APInt one(8, 1);
APInt two(8, 2);
APInt nine(8, 9);
APInt four(8, 4);
EXPECT_EQ(nine.srem(two), one);
EXPECT_EQ(nine.srem(-two), one);
EXPECT_EQ((-nine).srem(two), -one);
EXPECT_EQ((-nine).srem(-two), -one);
APInt::sdivrem(nine, two, q, r);
EXPECT_EQ(four, q);
EXPECT_EQ(one, r);
APInt::sdivrem(-nine, two, q, r);
EXPECT_EQ(-four, q);
EXPECT_EQ(-one, r);
APInt::sdivrem(nine, -two, q, r);
EXPECT_EQ(-four, q);
EXPECT_EQ(one, r);
APInt::sdivrem(-nine, -two, q, r);
EXPECT_EQ(four, q);
EXPECT_EQ(-one, r);
}
}
TEST(APIntTest, fromString) {