mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-06-17 04:24:00 +00:00
Refuse to (even try to) vectorize loops which have uniform writes,
even if erroneously annotated with the parallel loop metadata. Fixes Bug 15794: "Loop Vectorizer: Crashes with the use of llvm.loop.parallel metadata" git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@180081 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
@ -2548,13 +2548,6 @@ LoopVectorizationLegality::hasPossibleGlobalWriteReorder(
|
||||
|
||||
bool LoopVectorizationLegality::canVectorizeMemory() {
|
||||
|
||||
if (TheLoop->isAnnotatedParallel()) {
|
||||
DEBUG(dbgs()
|
||||
<< "LV: A loop annotated parallel, ignore memory dependency "
|
||||
<< "checks.\n");
|
||||
return true;
|
||||
}
|
||||
|
||||
typedef SmallVector<Value*, 16> ValueVector;
|
||||
typedef SmallPtrSet<Value*, 16> ValueSet;
|
||||
// Holds the Load and Store *instructions*.
|
||||
@ -2577,7 +2570,7 @@ bool LoopVectorizationLegality::canVectorizeMemory() {
|
||||
if (it->mayReadFromMemory()) {
|
||||
LoadInst *Ld = dyn_cast<LoadInst>(it);
|
||||
if (!Ld) return false;
|
||||
if (!Ld->isSimple()) {
|
||||
if (!Ld->isSimple() && !TheLoop->isAnnotatedParallel()) {
|
||||
DEBUG(dbgs() << "LV: Found a non-simple load.\n");
|
||||
return false;
|
||||
}
|
||||
@ -2589,7 +2582,7 @@ bool LoopVectorizationLegality::canVectorizeMemory() {
|
||||
if (it->mayWriteToMemory()) {
|
||||
StoreInst *St = dyn_cast<StoreInst>(it);
|
||||
if (!St) return false;
|
||||
if (!St->isSimple()) {
|
||||
if (!St->isSimple() && !TheLoop->isAnnotatedParallel()) {
|
||||
DEBUG(dbgs() << "LV: Found a non-simple store.\n");
|
||||
return false;
|
||||
}
|
||||
@ -2636,6 +2629,13 @@ bool LoopVectorizationLegality::canVectorizeMemory() {
|
||||
ReadWrites.insert(std::make_pair(Ptr, ST));
|
||||
}
|
||||
|
||||
if (TheLoop->isAnnotatedParallel()) {
|
||||
DEBUG(dbgs()
|
||||
<< "LV: A loop annotated parallel, ignore memory dependency "
|
||||
<< "checks.\n");
|
||||
return true;
|
||||
}
|
||||
|
||||
for (I = Loads.begin(), IE = Loads.end(); I != IE; ++I) {
|
||||
LoadInst *LD = cast<LoadInst>(*I);
|
||||
Value* Ptr = LD->getPointerOperand();
|
||||
|
Reference in New Issue
Block a user