From aa781b34040f07db00fb4b59cb567e6ad9ef5861 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Thu, 17 Feb 2005 19:40:32 +0000 Subject: [PATCH] Don't sink argument loads into loops or other bad places. This disables folding of argument loads with instructions that are not in the entry block. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@20228 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp b/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp index e5266c294f8..285f810bfbe 100644 --- a/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp +++ b/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp @@ -852,7 +852,14 @@ static BasicBlock *IsOnlyUsedInOneBasicBlock(Argument *A) { ++UI) if (isa(*UI) || cast(*UI)->getParent() != BB) return 0; // Disagreement among the users? - return BB; + + // Okay, there is a single BB user. Only permit this optimization if this is + // the entry block, otherwise, we might sink argument loads into loops and + // stuff. Later, when we have global instruction selection, this won't be an + // issue clearly. + if (BB == BB->getParent()->begin()) + return BB; + return 0; } void SelectionDAGISel::