diff --git a/lib/Transforms/IPO/GlobalOpt.cpp b/lib/Transforms/IPO/GlobalOpt.cpp index b888e959820..b1ba6be5ff6 100644 --- a/lib/Transforms/IPO/GlobalOpt.cpp +++ b/lib/Transforms/IPO/GlobalOpt.cpp @@ -962,7 +962,9 @@ static bool OptimizeAwayTrappingUsesOfLoads(GlobalVariable *GV, Constant *LV, // If we get here we could have other crazy uses that are transitively // loaded. assert((isa(GlobalUser) || isa(GlobalUser) || - isa(GlobalUser) || isa(GlobalUser)) && + isa(GlobalUser) || isa(GlobalUser) || + isa(GlobalUser) || + isa(GlobalUser)) && "Only expect load and stores!"); } } diff --git a/test/Transforms/GlobalOpt/load-store-global.ll b/test/Transforms/GlobalOpt/load-store-global.ll index f824b2c11cb..25a53370fa0 100644 --- a/test/Transforms/GlobalOpt/load-store-global.ll +++ b/test/Transforms/GlobalOpt/load-store-global.ll @@ -1,15 +1,38 @@ -; RUN: opt < %s -globalopt -S | not grep G +; RUN: opt < %s -globalopt -S | FileCheck %s @G = internal global i32 17 ; [#uses=3] +; CHECK-NOT: @G define void @foo() { %V = load i32* @G ; [#uses=1] store i32 %V, i32* @G ret void +; CHECK: @foo +; CHECK-NEXT: ret void } define i32 @bar() { %X = load i32* @G ; [#uses=1] ret i32 %X +; CHECK: @bar +; CHECK-NEXT: ret i32 17 +} + +@a = internal global i64* null, align 8 +; CHECK-NOT: @a + +; PR13968 +define void @qux() nounwind { + %b = bitcast i64** @a to i8* + %g = getelementptr i64** @a, i32 1 + %cmp = icmp ne i8* null, %b + %cmp2 = icmp eq i8* null, %b + %cmp3 = icmp eq i64** null, %g + store i64* inttoptr (i64 1 to i64*), i64** @a, align 8 + %l = load i64** @a, align 8 + ret void +; CHECK: @qux +; CHECK-NOT: store +; CHECK-NOT: load }