diff --git a/lib/Target/X86/X86ISelDAGToDAG.cpp b/lib/Target/X86/X86ISelDAGToDAG.cpp index 33c80c750ef..32ad1aaa604 100644 --- a/lib/Target/X86/X86ISelDAGToDAG.cpp +++ b/lib/Target/X86/X86ISelDAGToDAG.cpp @@ -79,7 +79,8 @@ namespace { } bool hasBaseOrIndexReg() const { - return IndexReg.getNode() != 0 || Base_Reg.getNode() != 0; + return BaseType == FrameIndexBase || + IndexReg.getNode() != 0 || Base_Reg.getNode() != 0; } /// isRIPRelative - Return true if this addressing mode is already RIP diff --git a/test/CodeGen/X86/frame-base.ll b/test/CodeGen/X86/frame-base.ll new file mode 100644 index 00000000000..a6bd2a51c9a --- /dev/null +++ b/test/CodeGen/X86/frame-base.ll @@ -0,0 +1,22 @@ +; RUN: llc -mtriple=x86_64-apple-macosx -o - %s | FileCheck %s + +; The issue here was a conflict between forming a %rip-relative lea and a +; FrameIndex lea. The %rip sanity-checks didn't consider that a base register +; had been set if we'd already matched a FrameIndex, when it has in reality. + +@var = global i32 0 + +define void @test_frame_rip_conflict() { +; CHECK-LABEL: test_frame_rip_conflict: +; CHECK: leaq _var(%rip), [[TMPADDR:%r.*]] +; CHECK: leaq {{-?[0-9]+}}(%rsp,[[TMPADDR]]), + %stackvar = alloca i32 + + %stackint = ptrtoint i32* %stackvar to i64 + %addr = add i64 ptrtoint(i32* @var to i64), %stackint + + call void @eat_i64(i64 %addr) + ret void +} + +declare void @eat_i64(i64)