Options: explicit handling of --

Clients of the option parsing library should handle it explicitly
using a KIND_REMAINING_ARGS option.

Clang and lld have been updated in r188316 and r188318, respectively.

Also fix -Wsign-compare warning in the option parsing test.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@188323 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Hans Wennborg
2013-08-13 22:23:05 +00:00
parent 51a0280d29
commit b06ccefc91
2 changed files with 1 additions and 30 deletions

View File

@ -259,22 +259,6 @@ InputArgList *OptTable::ParseArgs(const char *const *ArgBegin,
continue;
}
// FIXME: Remove once clients are updated to use a KIND_REMAINING_ARGS
// option to handle this explicitly instead.
if (Str == "--") {
// Everything after -- is a filename.
++Index;
assert(TheInputOptionID != 0 && "Invalid input option ID.");
while (Index < End) {
Args->append(new Arg(getOption(TheInputOptionID),
Args->getArgString(Index), Index,
Args->getArgString(Index)));
++Index;
}
break;
}
unsigned Prev = Index;
Arg *A = ParseOneArg(*Args, Index, FlagsToInclude, FlagsToExclude);
assert(Index > Prev && "Parser failed to consume argument.");