mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-08-22 10:29:35 +00:00
Fixed RuntimeDyldELF absolute relocations.
If an ELF relocation is pointed at an absolute address, it will have a symbol ID of zero. RuntimeDyldELF::processRelocationRef was not previously handling this case, and was instead trying to handle it as a section-relative fixup. I think this is the right fix here, but my elf-fu is poor on some of the more exotic platforms, so I'd appreciate it if anyone with greater knowledge could verify this. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@188572 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
8ae1efeb07
commit
b0f7929885
@ -843,6 +843,13 @@ void RuntimeDyldELF::processRelocationRef(unsigned SectionID,
|
||||
case SymbolRef::ST_Unknown: {
|
||||
Value.SymbolName = TargetName.data();
|
||||
Value.Addend = Addend;
|
||||
|
||||
// Absolute relocations will have a zero symbol ID (STN_UNDEF), which
|
||||
// will manifest here as a NULL symbol name.
|
||||
// We can set this as a valid (but empty) symbol name, and rely
|
||||
// on addRelocationForSymbol to handle this.
|
||||
if (!Value.SymbolName)
|
||||
Value.SymbolName = "";
|
||||
break;
|
||||
}
|
||||
default:
|
||||
@ -1068,7 +1075,10 @@ void RuntimeDyldELF::processRelocationRef(unsigned SectionID,
|
||||
RelocationEntry RE(SectionID, Offset, RelType, Value.Addend);
|
||||
// Extra check to avoid relocation againt empty symbols (usually
|
||||
// the R_PPC64_TOC).
|
||||
if (Value.SymbolName && !TargetName.empty())
|
||||
if (SymType != SymbolRef::ST_Unknown && TargetName.empty())
|
||||
Value.SymbolName = NULL;
|
||||
|
||||
if (Value.SymbolName)
|
||||
addRelocationForSymbol(RE, Value.SymbolName);
|
||||
else
|
||||
addRelocationForSection(RE, Value.SectionID);
|
||||
|
Loading…
Reference in New Issue
Block a user