From b1a464279623768a3d04ff6726c99dce35d2f360 Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Fri, 20 Jul 2012 18:29:34 +0000 Subject: [PATCH] lit: Use close_fds=True on UNIX, to avoid file descriptor pollution of subprocesses. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@160556 91177308-0d34-0410-b5e6-96231b3b80d8 --- utils/lit/lit/TestRunner.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/utils/lit/lit/TestRunner.py b/utils/lit/lit/TestRunner.py index 3004d2c7134..71882b76f8b 100644 --- a/utils/lit/lit/TestRunner.py +++ b/utils/lit/lit/TestRunner.py @@ -24,11 +24,15 @@ kUseCloseFDs = not kIsWindows kAvoidDevNull = kIsWindows def executeCommand(command, cwd=None, env=None): + # Close extra file handles on UNIX (on Windows this cannot be done while + # also redirecting input). + close_fds = not kIsWindows + p = subprocess.Popen(command, cwd=cwd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, - env=env) + env=env, close_fds=close_fds) out,err = p.communicate() exitCode = p.wait()