6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-02-19 06:31:18 +00:00
Code Issues Projects Releases Wiki Activity

Fix integer overflow bug in raw_ostream::write. This showed up as a

Browse Source 
non-deterministic crash in the test suite. Fixes PR10055!


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@138717 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Nick Lewycky 2011-08-28 03:30:02 +00:00
parent f5ec9b55e8
commit b1b051ec97
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Support/raw_ostream.cpp
View File

@ -84,7 +84,7 @@ void raw_ostream::SetBuffered() {
} }
void raw_ostream::SetBufferAndMode(char *BufferStart, size_t Size, void raw_ostream::SetBufferAndMode(char *BufferStart, size_t Size,
BufferKind Mode) { BufferKind Mode) {
assert(((Mode == Unbuffered && BufferStart == 0 && Size == 0) || assert(((Mode == Unbuffered && BufferStart == 0 && Size == 0) ||
(Mode != Unbuffered && BufferStart && Size)) && (Mode != Unbuffered && BufferStart && Size)) &&
"stream must be unbuffered or have at least one byte"); "stream must be unbuffered or have at least one byte");
@ -284,7 +284,7 @@ raw_ostream &raw_ostream::write(unsigned char C) {
raw_ostream &raw_ostream::write(const char *Ptr, size_t Size) { raw_ostream &raw_ostream::write(const char *Ptr, size_t Size) {
// Group exceptional cases into a single branch. // Group exceptional cases into a single branch.
if (BUILTIN_EXPECT(OutBufCur+Size > OutBufEnd, false)) { if (BUILTIN_EXPECT(size_t(OutBufEnd - OutBufCur) < Size, false)) {
if (BUILTIN_EXPECT(!OutBufStart, false)) { if (BUILTIN_EXPECT(!OutBufStart, false)) {
if (BufferMode == Unbuffered) { if (BufferMode == Unbuffered) {
write_impl(Ptr, Size); write_impl(Ptr, Size);