Simplify compression API by decompressing into a SmallVector rather than a MemoryBuffer

This avoids an extra copy during decompression and avoids the use of
MemoryBuffer which is a weirdly esoteric device that includes unrelated
concepts like "file name" (its rather generic name is a bit misleading).

Similar refactoring of zlib::compress coming up.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@205676 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Blaikie
2014-04-05 21:26:44 +00:00
parent 48ee81c679
commit b206103abc
5 changed files with 18 additions and 22 deletions

View File

@ -25,14 +25,13 @@ namespace {
void TestZlibCompression(StringRef Input, zlib::CompressionLevel Level) {
std::unique_ptr<MemoryBuffer> Compressed;
std::unique_ptr<MemoryBuffer> Uncompressed;
SmallString<32> Uncompressed;
EXPECT_EQ(zlib::StatusOK, zlib::compress(Input, Compressed, Level));
// Check that uncompressed buffer is the same as original.
EXPECT_EQ(zlib::StatusOK, zlib::uncompress(Compressed->getBuffer(),
Uncompressed, Input.size()));
EXPECT_EQ(Input.size(), Uncompressed->getBufferSize());
EXPECT_EQ(0,
memcmp(Input.data(), Uncompressed->getBufferStart(), Input.size()));
EXPECT_EQ(Input.size(), Uncompressed.size());
EXPECT_EQ(0, memcmp(Input.data(), Uncompressed.data(), Input.size()));
if (Input.size() > 0) {
// Uncompression fails if expected length is too short.
EXPECT_EQ(zlib::StatusBufferTooShort,