mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-07-25 13:24:46 +00:00
[LV] Move addRuntimeCheck to LoopAccessAnalysis
This will allow it to be shared with the new Loop Distribution pass. getFirstInst is currently duplicated across LoopVectorize.cpp and LoopAccessAnalysis.cpp. This is a short-term work-around until we figure out a better solution. NFC. (The code moved is adjusted a bit for the name of the Loop member and that PtrRtCheck is now a reference rather than a pointer.) git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@228418 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
@@ -14,9 +14,11 @@
|
||||
|
||||
#include "llvm/Analysis/LoopAccessAnalysis.h"
|
||||
#include "llvm/Analysis/LoopInfo.h"
|
||||
#include "llvm/Analysis/ScalarEvolutionExpander.h"
|
||||
#include "llvm/Analysis/ValueTracking.h"
|
||||
#include "llvm/IR/DiagnosticInfo.h"
|
||||
#include "llvm/IR/Dominators.h"
|
||||
#include "llvm/IR/IRBuilder.h"
|
||||
#include "llvm/Support/Debug.h"
|
||||
#include "llvm/Transforms/Utils/VectorUtils.h"
|
||||
using namespace llvm;
|
||||
@@ -1082,3 +1084,107 @@ void LoopAccessAnalysis::emitAnalysis(VectorizationReport &Message) {
|
||||
bool LoopAccessAnalysis::isUniform(Value *V) {
|
||||
return (SE->isLoopInvariant(SE->getSCEV(V), TheLoop));
|
||||
}
|
||||
|
||||
// FIXME: this function is currently a duplicate of the one in
|
||||
// LoopVectorize.cpp.
|
||||
static Instruction *getFirstInst(Instruction *FirstInst, Value *V,
|
||||
Instruction *Loc) {
|
||||
if (FirstInst)
|
||||
return FirstInst;
|
||||
if (Instruction *I = dyn_cast<Instruction>(V))
|
||||
return I->getParent() == Loc->getParent() ? I : nullptr;
|
||||
return nullptr;
|
||||
}
|
||||
|
||||
std::pair<Instruction *, Instruction *>
|
||||
LoopAccessAnalysis::addRuntimeCheck(Instruction *Loc) {
|
||||
Instruction *tnullptr = nullptr;
|
||||
if (!PtrRtCheck.Need)
|
||||
return std::pair<Instruction *, Instruction *>(tnullptr, tnullptr);
|
||||
|
||||
unsigned NumPointers = PtrRtCheck.Pointers.size();
|
||||
SmallVector<TrackingVH<Value> , 2> Starts;
|
||||
SmallVector<TrackingVH<Value> , 2> Ends;
|
||||
|
||||
LLVMContext &Ctx = Loc->getContext();
|
||||
SCEVExpander Exp(*SE, "induction");
|
||||
Instruction *FirstInst = nullptr;
|
||||
|
||||
for (unsigned i = 0; i < NumPointers; ++i) {
|
||||
Value *Ptr = PtrRtCheck.Pointers[i];
|
||||
const SCEV *Sc = SE->getSCEV(Ptr);
|
||||
|
||||
if (SE->isLoopInvariant(Sc, TheLoop)) {
|
||||
DEBUG(dbgs() << "LV: Adding RT check for a loop invariant ptr:" <<
|
||||
*Ptr <<"\n");
|
||||
Starts.push_back(Ptr);
|
||||
Ends.push_back(Ptr);
|
||||
} else {
|
||||
DEBUG(dbgs() << "LV: Adding RT check for range:" << *Ptr << '\n');
|
||||
unsigned AS = Ptr->getType()->getPointerAddressSpace();
|
||||
|
||||
// Use this type for pointer arithmetic.
|
||||
Type *PtrArithTy = Type::getInt8PtrTy(Ctx, AS);
|
||||
|
||||
Value *Start = Exp.expandCodeFor(PtrRtCheck.Starts[i], PtrArithTy, Loc);
|
||||
Value *End = Exp.expandCodeFor(PtrRtCheck.Ends[i], PtrArithTy, Loc);
|
||||
Starts.push_back(Start);
|
||||
Ends.push_back(End);
|
||||
}
|
||||
}
|
||||
|
||||
IRBuilder<> ChkBuilder(Loc);
|
||||
// Our instructions might fold to a constant.
|
||||
Value *MemoryRuntimeCheck = nullptr;
|
||||
for (unsigned i = 0; i < NumPointers; ++i) {
|
||||
for (unsigned j = i+1; j < NumPointers; ++j) {
|
||||
// No need to check if two readonly pointers intersect.
|
||||
if (!PtrRtCheck.IsWritePtr[i] && !PtrRtCheck.IsWritePtr[j])
|
||||
continue;
|
||||
|
||||
// Only need to check pointers between two different dependency sets.
|
||||
if (PtrRtCheck.DependencySetId[i] == PtrRtCheck.DependencySetId[j])
|
||||
continue;
|
||||
// Only need to check pointers in the same alias set.
|
||||
if (PtrRtCheck.AliasSetId[i] != PtrRtCheck.AliasSetId[j])
|
||||
continue;
|
||||
|
||||
unsigned AS0 = Starts[i]->getType()->getPointerAddressSpace();
|
||||
unsigned AS1 = Starts[j]->getType()->getPointerAddressSpace();
|
||||
|
||||
assert((AS0 == Ends[j]->getType()->getPointerAddressSpace()) &&
|
||||
(AS1 == Ends[i]->getType()->getPointerAddressSpace()) &&
|
||||
"Trying to bounds check pointers with different address spaces");
|
||||
|
||||
Type *PtrArithTy0 = Type::getInt8PtrTy(Ctx, AS0);
|
||||
Type *PtrArithTy1 = Type::getInt8PtrTy(Ctx, AS1);
|
||||
|
||||
Value *Start0 = ChkBuilder.CreateBitCast(Starts[i], PtrArithTy0, "bc");
|
||||
Value *Start1 = ChkBuilder.CreateBitCast(Starts[j], PtrArithTy1, "bc");
|
||||
Value *End0 = ChkBuilder.CreateBitCast(Ends[i], PtrArithTy1, "bc");
|
||||
Value *End1 = ChkBuilder.CreateBitCast(Ends[j], PtrArithTy0, "bc");
|
||||
|
||||
Value *Cmp0 = ChkBuilder.CreateICmpULE(Start0, End1, "bound0");
|
||||
FirstInst = getFirstInst(FirstInst, Cmp0, Loc);
|
||||
Value *Cmp1 = ChkBuilder.CreateICmpULE(Start1, End0, "bound1");
|
||||
FirstInst = getFirstInst(FirstInst, Cmp1, Loc);
|
||||
Value *IsConflict = ChkBuilder.CreateAnd(Cmp0, Cmp1, "found.conflict");
|
||||
FirstInst = getFirstInst(FirstInst, IsConflict, Loc);
|
||||
if (MemoryRuntimeCheck) {
|
||||
IsConflict = ChkBuilder.CreateOr(MemoryRuntimeCheck, IsConflict,
|
||||
"conflict.rdx");
|
||||
FirstInst = getFirstInst(FirstInst, IsConflict, Loc);
|
||||
}
|
||||
MemoryRuntimeCheck = IsConflict;
|
||||
}
|
||||
}
|
||||
|
||||
// We have to do this trickery because the IRBuilder might fold the check to a
|
||||
// constant expression in which case there is no Instruction anchored in a
|
||||
// the block.
|
||||
Instruction *Check = BinaryOperator::CreateAnd(MemoryRuntimeCheck,
|
||||
ConstantInt::getTrue(Ctx));
|
||||
ChkBuilder.Insert(Check, "memcheck.conflict");
|
||||
FirstInst = getFirstInst(FirstInst, Check, Loc);
|
||||
return std::make_pair(FirstInst, Check);
|
||||
}
|
||||
|
Reference in New Issue
Block a user