mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-08-26 07:29:55 +00:00
Disable inlining of recursive calls. It can complicate tailcallelim and
dependent analyses, and increase code size, so doing it profitably would require more complex heuristics. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@101471 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
ea25b48af3
commit
b391bb8947
@ -263,6 +263,13 @@ InlineCost InlineCostAnalyzer::getInlineCost(CallSite CS,
|
|||||||
CS.isNoInline())
|
CS.isNoInline())
|
||||||
return llvm::InlineCost::getNever();
|
return llvm::InlineCost::getNever();
|
||||||
|
|
||||||
|
// Don't inline directly recursive calls, for now. Inlining a directly
|
||||||
|
// recursive call is effectively unrolling a loop, so it calls for different
|
||||||
|
// heuristics, which aren't implemented yet. Until then, err on the
|
||||||
|
// conservative side.
|
||||||
|
if (Callee == Caller)
|
||||||
|
return llvm::InlineCost::getNever();
|
||||||
|
|
||||||
// InlineCost - This value measures how good of an inline candidate this call
|
// InlineCost - This value measures how good of an inline candidate this call
|
||||||
// site is to inline. A lower inline cost make is more likely for the call to
|
// site is to inline. A lower inline cost make is more likely for the call to
|
||||||
// be inlined. This value may go negative.
|
// be inlined. This value may go negative.
|
||||||
|
29
test/Transforms/Inline/tail-recursion.ll
Normal file
29
test/Transforms/Inline/tail-recursion.ll
Normal file
@ -0,0 +1,29 @@
|
|||||||
|
; RUN: opt -inline -tailcallelim -indvars -loop-deletion -S < %s | FileCheck %s
|
||||||
|
|
||||||
|
; Inline shouldn't inline foo into itself because it's a tailcallelim
|
||||||
|
; candidate. Tailcallelim should convert the call into a loop. Indvars
|
||||||
|
; should calculate the exit value, making the loop dead. Loop deletion
|
||||||
|
; should delete the loop.
|
||||||
|
; PR6842
|
||||||
|
|
||||||
|
; CHECK: define i32 @bar() nounwind {
|
||||||
|
; CHECK-NEXT: ret i32 10000
|
||||||
|
; CHECK-NEXT: }
|
||||||
|
|
||||||
|
define internal i32 @foo(i32 %x) nounwind {
|
||||||
|
%i = add i32 %x, 1 ; <i32> [#uses=3]
|
||||||
|
%a = icmp slt i32 %i, 10000 ; <i1> [#uses=1]
|
||||||
|
br i1 %a, label %more, label %done
|
||||||
|
|
||||||
|
done: ; preds = %0
|
||||||
|
ret i32 %i
|
||||||
|
|
||||||
|
more: ; preds = %0
|
||||||
|
%z = tail call i32 @foo(i32 %i) ; <i32> [#uses=1]
|
||||||
|
ret i32 %z
|
||||||
|
}
|
||||||
|
|
||||||
|
define i32 @bar() nounwind {
|
||||||
|
%z = call i32 @foo(i32 0) ; <i32> [#uses=1]
|
||||||
|
ret i32 %z
|
||||||
|
}
|
Loading…
Reference in New Issue
Block a user