6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-23 17:24:48 +00:00
Code Issues Projects Releases Wiki Activity

Inliner: Non-local functions in COMDATs shouldn't be dropped

Browse Source 
A function with discardable linkage cannot be discarded if its a member
of a COMDAT group without considering all the other COMDAT members as
well.  This sort of thing is already handled by GlobalOpt/GlobalDCE.

This fixes PR21206.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@219335 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Majnemer
2014-10-08 19:32:32 +00:00
parent 0a5843e3b1
commit b5b306e6a9
2 changed files with 25 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Transforms/IPO/Inliner.cpp
View File

@ -669,6 +669,13 @@ bool Inliner::removeDeadFunctions(CallGraph &CG, bool AlwaysInlineOnly) {
if (!F->isDefTriviallyDead()) if (!F->isDefTriviallyDead())
continue; continue;
// It is unsafe to drop a function with discardable linkage from a COMDAT
// without also dropping the other members of the COMDAT.
// The inliner doesn't visit non-function entities which are in COMDAT
// groups so it is unsafe to do so *unless* the linkage is local.
if (!F->hasLocalLinkage() && F->hasComdat())
continue;
// Remove any call graph edges from the function to its callees. // Remove any call graph edges from the function to its callees.
CGN->removeAllCalledFunctions(); CGN->removeAllCalledFunctions();

18
test/Transforms/Inline/pr21206.ll Normal file
View File

@ -0,0 +1,18 @@
; RUN: opt < %s -inline -S | FileCheck %s
$c = comdat any
; CHECK: $c = comdat any
define linkonce_odr void @foo() comdat $c {
ret void
}
; CHECK: define linkonce_odr void @foo() comdat $c
define linkonce_odr void @bar() comdat $c {
ret void
}
; CHECK: define linkonce_odr void @bar() comdat $c
define void()* @zed() {
ret void()* @foo
}