From b6b12e59a263e3eb984505921352195e38ecddde Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Mon, 7 Jul 2014 20:34:51 +0000 Subject: [PATCH] Use raw_fd_ostream instead of std::ofstream. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@212483 91177308-0d34-0410-b5e6-96231b3b80d8 --- tools/gold/gold-plugin.cpp | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/tools/gold/gold-plugin.cpp b/tools/gold/gold-plugin.cpp index f424e46eb46..b90851019fe 100644 --- a/tools/gold/gold-plugin.cpp +++ b/tools/gold/gold-plugin.cpp @@ -28,7 +28,6 @@ #include #include #include -#include #include #include #include @@ -410,15 +409,17 @@ static bool mustPreserve(const claimed_file &F, int i) { /// been overridden by a native object file. Then, perform optimization and /// codegen. static ld_plugin_status all_symbols_read_hook(void) { - std::ofstream api_file; + // FIXME: raw_fd_ostream should be able to represent an unopened file. + std::unique_ptr api_file; + assert(CodeGen); if (options::generate_api_file) { - api_file.open("apifile.txt", std::ofstream::out | std::ofstream::trunc); - if (!api_file.is_open()) { - (*message)(LDPL_FATAL, "Unable to open apifile.txt for writing."); - abort(); - } + std::string Error; + api_file.reset(new raw_fd_ostream("apifile.txt", Error, sys::fs::F_None)); + if (!Error.empty()) + (*message)(LDPL_FATAL, "Unable to open apifile.txt for writing: %s", + Error.c_str()); } for (std::list::iterator I = Modules.begin(), @@ -431,14 +432,11 @@ static ld_plugin_status all_symbols_read_hook(void) { CodeGen->addMustPreserveSymbol(I->syms[i].name); if (options::generate_api_file) - api_file << I->syms[i].name << "\n"; + (*api_file) << I->syms[i].name << "\n"; } } } - if (options::generate_api_file) - api_file.close(); - CodeGen->setCodePICModel(output_type); CodeGen->setDebugInfo(LTO_DEBUG_MODEL_DWARF); if (!options::mcpu.empty())