6502/llvm-6502
1
0 Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2026-04-27 04:18:42 +00:00
Code Issues Projects Releases Wiki Activity

llvm-cov: Don't pointlessly create a unique_ptr (NFC)

Browse Source 
There's no ownership going on here, and no reason to heap allocate
this object.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217113 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Justin Bogner committed 2014-09-04 00:04:54 +00:00
1 parent c7ad7ec8b9
commit b79ed97962
1 file changed
+7 -9
Download Patch File Download Diff File Expand all files Collapse all files
tools/llvm-cov/CodeCoverage.cpp
+7 -9
View File
@@ -615,18 +615,17 @@ int CodeCoverageTool::show(int argc, const char **argv,
if (findMainViewFileID(Function, MainFileID)) if (findMainViewFileID(Function, MainFileID))
continue; continue;
StringRef SourceFile = Function.Filenames[MainFileID]; StringRef SourceFile = Function.Filenames[MainFileID];
std::unique_ptr<SourceCoverageView> mainView;
auto SourceBuffer = getSourceFile(SourceFile); auto SourceBuffer = getSourceFile(SourceFile);
if (!SourceBuffer) if (!SourceBuffer)
return 1; return 1;
auto Range = findExpandedFileInterestingLineRange(MainFileID, Function); auto Range = findExpandedFileInterestingLineRange(MainFileID, Function);
mainView.reset(new SourceCoverageView(SourceBuffer.get(), ViewOpts, SourceCoverageView mainView(SourceBuffer.get(), ViewOpts, Range.first,
Range.first, Range.second)); Range.second);
createSourceFileView(SourceFile, *mainView, Function, true); createSourceFileView(SourceFile, mainView, Function, true);
ViewOpts.colored_ostream(outs(), raw_ostream::CYAN) ViewOpts.colored_ostream(outs(), raw_ostream::CYAN)
<< Function.PrettyName << " from " << SourceFile << ":"; << Function.PrettyName << " from " << SourceFile << ":";
outs() << "\n"; outs() << "\n";
mainView->render(outs()); mainView.render(outs());
if (FunctionMappingRecords.size() > 1) if (FunctionMappingRecords.size() > 1)
outs() << "\n"; outs() << "\n";
} }
@@ -648,12 +647,11 @@ int CodeCoverageTool::show(int argc, const char **argv,
} }
for (const auto &SourceFile : SourceFiles) { for (const auto &SourceFile : SourceFiles) {
std::unique_ptr<SourceCoverageView> mainView;
auto SourceBuffer = getSourceFile(SourceFile); auto SourceBuffer = getSourceFile(SourceFile);
if (!SourceBuffer) if (!SourceBuffer)
return 1; return 1;
mainView.reset(new SourceCoverageView(SourceBuffer.get(), ViewOpts)); SourceCoverageView mainView(SourceBuffer.get(), ViewOpts);
if (createSourceFileView(SourceFile, *mainView, FunctionMappingRecords)) { if (createSourceFileView(SourceFile, mainView, FunctionMappingRecords)) {
ViewOpts.colored_ostream(outs(), raw_ostream::RED) ViewOpts.colored_ostream(outs(), raw_ostream::RED)
<< "warning: The file '" << SourceFile << "' isn't covered."; << "warning: The file '" << SourceFile << "' isn't covered.";
outs() << "\n"; outs() << "\n";
@@ -664,7 +662,7 @@ int CodeCoverageTool::show(int argc, const char **argv,
ViewOpts.colored_ostream(outs(), raw_ostream::CYAN) << SourceFile << ":"; ViewOpts.colored_ostream(outs(), raw_ostream::CYAN) << SourceFile << ":";
outs() << "\n"; outs() << "\n";
} }
mainView->render(outs()); mainView.render(outs());
if (SourceFiles.size() > 1) if (SourceFiles.size() > 1)
outs() << "\n"; outs() << "\n";
} }