pass stringref by value instead of by const&

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@95627 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2010-02-09 00:34:28 +00:00
parent 159f527cb2
commit b8d6e98e56
3 changed files with 13 additions and 12 deletions

View File

@ -69,7 +69,7 @@ public:
}
static unsigned MatchRegisterName(const StringRef &Name);
static unsigned MatchRegisterName(StringRef Name);
AsmToken X86AsmLexer::LexTokenATT() {
const AsmToken lexedToken = lexDefinite();

View File

@ -67,7 +67,7 @@ public:
/// @name Auto-generated Match Functions
/// {
static unsigned MatchRegisterName(const StringRef &Name);
static unsigned MatchRegisterName(StringRef Name);
/// }
@ -291,6 +291,7 @@ bool X86ATTAsmParser::ParseRegister(unsigned &RegNo,
// FIXME: Validate register for the current architecture; we have to do
// validation later, so maybe there is no need for this here.
RegNo = MatchRegisterName(Tok.getString());
if (RegNo == 0)
return Error(Tok.getLoc(), "invalid register name");

View File

@ -140,7 +140,7 @@ static std::string FlattenVariants(const std::string &AsmString,
}
/// TokenizeAsmString - Tokenize a simplified assembly string.
static void TokenizeAsmString(const StringRef &AsmString,
static void TokenizeAsmString(StringRef AsmString,
SmallVectorImpl<StringRef> &Tokens) {
unsigned Prev = 0;
bool InTok = true;
@ -207,7 +207,7 @@ static void TokenizeAsmString(const StringRef &AsmString,
Tokens.push_back(AsmString.substr(Prev));
}
static bool IsAssemblerInstruction(const StringRef &Name,
static bool IsAssemblerInstruction(StringRef Name,
const CodeGenInstruction &CGI,
const SmallVectorImpl<StringRef> &Tokens) {
// Ignore "codegen only" instructions.
@ -528,10 +528,10 @@ private:
private:
/// getTokenClass - Lookup or create the class for the given token.
ClassInfo *getTokenClass(const StringRef &Token);
ClassInfo *getTokenClass(StringRef Token);
/// getOperandClass - Lookup or create the class for the given operand.
ClassInfo *getOperandClass(const StringRef &Token,
ClassInfo *getOperandClass(StringRef Token,
const CodeGenInstruction::OperandInfo &OI);
/// BuildRegisterClasses - Build the ClassInfo* instances for register
@ -581,7 +581,7 @@ void InstructionInfo::dump() {
}
}
static std::string getEnumNameForToken(const StringRef &Str) {
static std::string getEnumNameForToken(StringRef Str) {
std::string Res;
for (StringRef::iterator it = Str.begin(), ie = Str.end(); it != ie; ++it) {
@ -603,7 +603,7 @@ static std::string getEnumNameForToken(const StringRef &Str) {
}
/// getRegisterRecord - Get the register record for \arg name, or 0.
static Record *getRegisterRecord(CodeGenTarget &Target, const StringRef &Name) {
static Record *getRegisterRecord(CodeGenTarget &Target, StringRef Name) {
for (unsigned i = 0, e = Target.getRegisters().size(); i != e; ++i) {
const CodeGenRegister &Reg = Target.getRegisters()[i];
if (Name == Reg.TheDef->getValueAsString("AsmName"))
@ -613,7 +613,7 @@ static Record *getRegisterRecord(CodeGenTarget &Target, const StringRef &Name) {
return 0;
}
ClassInfo *AsmMatcherInfo::getTokenClass(const StringRef &Token) {
ClassInfo *AsmMatcherInfo::getTokenClass(StringRef Token) {
ClassInfo *&Entry = TokenClasses[Token];
if (!Entry) {
@ -631,7 +631,7 @@ ClassInfo *AsmMatcherInfo::getTokenClass(const StringRef &Token) {
}
ClassInfo *
AsmMatcherInfo::getOperandClass(const StringRef &Token,
AsmMatcherInfo::getOperandClass(StringRef Token,
const CodeGenInstruction::OperandInfo &OI) {
if (OI.Rec->isSubClassOf("RegisterClass")) {
ClassInfo *CI = RegisterClassClasses[OI.Rec];
@ -1373,7 +1373,7 @@ static void EmitMatchTokenString(CodeGenTarget &Target,
Matches.push_back(StringPair(CI.ValueName, "return " + CI.Name + ";"));
}
OS << "static MatchClassKind MatchTokenString(const StringRef &Name) {\n";
OS << "static MatchClassKind MatchTokenString(StringRef Name) {\n";
EmitStringMatcher("Name", Matches, OS);
@ -1396,7 +1396,7 @@ static void EmitMatchRegisterName(CodeGenTarget &Target, Record *AsmParser,
"return " + utostr(i + 1) + ";"));
}
OS << "static unsigned MatchRegisterName(const StringRef &Name) {\n";
OS << "static unsigned MatchRegisterName(StringRef Name) {\n";
EmitStringMatcher("Name", Matches, OS);