6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-16 12:24:03 +00:00
Code Issues Projects Releases Wiki Activity

Avoid reconstructing the pointer set when searching for duplicated read/write pointers.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166205 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Nadav Rotem
2012-10-18 18:34:50 +00:00
parent e700f06054
commit b943d9d497
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/Transforms/Vectorize/LoopVectorize.cpp
View File

@ -166,7 +166,7 @@ private:
// Check if a pointer value is known to be disjoint. // Check if a pointer value is known to be disjoint.
// Example: Alloca, Global, NoAlias. // Example: Alloca, Global, NoAlias.
bool isKnownDisjoint(Value* Val); bool isidentifiedSafeObject(Value* Val);
/// The loop that we evaluate. /// The loop that we evaluate.
Loop *TheLoop; Loop *TheLoop;
@ -818,34 +818,31 @@ bool LoopVectorizationLegality::canVectorizeBlock(BasicBlock &BB) {
// disjoint memory locations, or that they are no-alias arguments. // disjoint memory locations, or that they are no-alias arguments.
ValueVector::iterator r, re, w, we; ValueVector::iterator r, re, w, we;
for (r = Reads.begin(), re = Reads.end(); r != re; ++r) { for (r = Reads.begin(), re = Reads.end(); r != re; ++r) {
if (!isKnownDisjoint(*r)) { if (!isidentifiedSafeObject(*r)) {
DEBUG(dbgs() << "LV: Found a bad read Ptr: "<< **r << "\n"); DEBUG(dbgs() << "LV: Found a bad read Ptr: "<< **r << "\n");
return false; return false;
} }
} }
for (w = Writes.begin(), we = Writes.end(); w != we; ++w) { for (w = Writes.begin(), we = Writes.end(); w != we; ++w) {
if (!isKnownDisjoint(*w)) { if (!isidentifiedSafeObject(*w)) {
DEBUG(dbgs() << "LV: Found a bad write Ptr: "<< **w << "\n"); DEBUG(dbgs() << "LV: Found a bad write Ptr: "<< **w << "\n");
return false; return false;
} }
} }
// Check that there are no multiple write locations to the same pointer. // Check that there are no multiple write locations to the same pointer.
SmallPtrSet<Value*, 8> BasePointers; SmallPtrSet<Value*, 8> WritePointerSet;
for (w = Writes.begin(), we = Writes.end(); w != we; ++w) { for (w = Writes.begin(), we = Writes.end(); w != we; ++w) {
if (BasePointers.count(*w)) { if (!WritePointerSet.insert(*w)) {
DEBUG(dbgs() << "LV: Multiple writes to the same index :"<< **w << "\n"); DEBUG(dbgs() << "LV: Multiple writes to the same index :"<< **w << "\n");
return false; return false;
} }
BasePointers.insert(*w);
} }
// Sort the writes vector so that we can use a binary search.
std::sort(Writes.begin(), Writes.end());
// Check that the reads and the writes are disjoint. // Check that the reads and the writes are disjoint.
for (r = Reads.begin(), re = Reads.end(); r != re; ++r) { for (r = Reads.begin(), re = Reads.end(); r != re; ++r) {
if (std::binary_search(Writes.begin(), Writes.end(), *r)) { if (WritePointerSet.count(*r)) {
DEBUG(dbgs() << "Vectorizer: Found a read/write ptr:"<< **r << "\n"); DEBUG(dbgs() << "Vectorizer: Found a read/write ptr:"<< **r << "\n");
return false; return false;
} }
@ -857,7 +854,7 @@ bool LoopVectorizationLegality::canVectorizeBlock(BasicBlock &BB) {
/// Checks if the value is a Global variable or if it is an Arguments /// Checks if the value is a Global variable or if it is an Arguments
/// marked with the NoAlias attribute. /// marked with the NoAlias attribute.
bool LoopVectorizationLegality::isKnownDisjoint(Value* Val) { bool LoopVectorizationLegality::isidentifiedSafeObject(Value* Val) {
assert(Val && "Invalid value"); assert(Val && "Invalid value");
if (dyn_cast<GlobalValue>(Val)) if (dyn_cast<GlobalValue>(Val))
return true; return true;