From bc076665cbf87caf79af5b80b9d57222d625428f Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Thu, 10 Nov 2005 21:47:01 +0000 Subject: [PATCH] speedup the common case where nothing needs to be quoted git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@24294 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/VMCore/Mangler.cpp | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/lib/VMCore/Mangler.cpp b/lib/VMCore/Mangler.cpp index 44fe1003140..264b84c6fe3 100644 --- a/lib/VMCore/Mangler.cpp +++ b/lib/VMCore/Mangler.cpp @@ -65,16 +65,29 @@ std::string Mangler::makeNameProper(const std::string &X, const char *Prefix) { if (*I >= '0' && *I <= '9') NeedsQuotes = true; - for (std::string::const_iterator E = X.end(); I != E; ++I) + // Do an initial scan of the string, checking to see if we need quotes or + // to escape a '"' or not. + if (!NeedsQuotes) + for (std::string::const_iterator E = X.end(); I != E; ++I) + if (!isCharAcceptable(*I)) { + NeedsQuotes = true; + break; + } + + // In the common case, we don't need quotes. Handle this quickly. + if (!NeedsQuotes) + return Result + X; + + // Otherwise, construct the string the expensive way. + I = X.begin(); + if (*I == 1) ++I; // Skip the marker if present. + for (std::string::const_iterator E = X.end(); I != E; ++I) { if (*I == '"') Result += "_QQ_"; - else { - if (!isCharAcceptable(*I)) - NeedsQuotes = true; + else Result += *I; - } - if (NeedsQuotes) - Result = '"' + Result + '"'; + } + Result = '"' + Result + '"'; } return Result; }