diff --git a/lib/Transforms/IPO/GlobalOpt.cpp b/lib/Transforms/IPO/GlobalOpt.cpp index 5c96317a8a5..c3a21b42389 100644 --- a/lib/Transforms/IPO/GlobalOpt.cpp +++ b/lib/Transforms/IPO/GlobalOpt.cpp @@ -486,7 +486,8 @@ static GlobalVariable *SRAGlobal(GlobalVariable *GV, const TargetData &TD) { GlobalVariable::InternalLinkage, In, GV->getName()+"."+utostr(i), (Module *)NULL, - GV->isThreadLocal()); + GV->isThreadLocal(), + GV->getType()->getAddressSpace()); Globals.insert(GV, NGV); NewGlobals.push_back(NGV); @@ -520,7 +521,8 @@ static GlobalVariable *SRAGlobal(GlobalVariable *GV, const TargetData &TD) { GlobalVariable::InternalLinkage, In, GV->getName()+"."+utostr(i), (Module *)NULL, - GV->isThreadLocal()); + GV->isThreadLocal(), + GV->getType()->getAddressSpace()); Globals.insert(GV, NGV); NewGlobals.push_back(NGV); diff --git a/test/Transforms/GlobalOpt/2008-07-17-addrspace.ll b/test/Transforms/GlobalOpt/2008-07-17-addrspace.ll new file mode 100644 index 00000000000..fd9d0885f27 --- /dev/null +++ b/test/Transforms/GlobalOpt/2008-07-17-addrspace.ll @@ -0,0 +1,28 @@ +; This test lets globalopt split the global struct and array into different +; values. This used to crash, because globalopt forgot to put the new var in the +; same address space as the old one. + +; RUN: llvm-as < %s | opt -globalopt | llvm-dis > %t +; Check that the new global values still have their address space +; RUN: cat %t | grep global.*addrspace + +@struct = internal global { i32, i32 } zeroinitializer addrspace(1) +@array = internal global [ 2 x i32 ] zeroinitializer addrspace(1) + +define i32 @foo() { + %A = load i32 addrspace(1) * getelementptr ({ i32, i32 } addrspace(1) * @struct, i32 0, i32 0) + %B = load i32 addrspace(1) * getelementptr ([ 2 x i32 ] addrspace(1) * @array, i32 0, i32 0) + ; Use the loaded values, so they won't get removed completely + %R = add i32 %A, %B + ret i32 %R +} + +; We put stores in a different function, so that the global variables won't get +; optimized away completely. +define void @bar(i32 %R) { + store i32 %R, i32 addrspace(1) * getelementptr ([ 2 x i32 ] addrspace(1) * @array, i32 0, i32 0) + store i32 %R, i32 addrspace(1) * getelementptr ({ i32, i32 } addrspace(1) * @struct, i32 0, i32 0) + ret void +} + +