From be9dfcef82c58063708e039bea3cf972ba41581b Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Thu, 28 Jan 2010 00:05:10 +0000 Subject: [PATCH] rename printVisibility to EmitVisibility and make it private, constify EmitLinkage. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@94705 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/CodeGen/AsmPrinter.h | 10 +++++----- lib/CodeGen/AsmPrinter/AsmPrinter.cpp | 11 +++++------ 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/include/llvm/CodeGen/AsmPrinter.h b/include/llvm/CodeGen/AsmPrinter.h index 52ac5476214..589788a7cc4 100644 --- a/include/llvm/CodeGen/AsmPrinter.h +++ b/include/llvm/CodeGen/AsmPrinter.h @@ -354,15 +354,15 @@ namespace llvm { /// printKill - This method prints the specified kill machine instruction. void printKill(const MachineInstr *MI) const; - /// printVisibility - This prints visibility information about symbol, if - /// this is suported by the target. - void printVisibility(MCSymbol *Sym, unsigned Visibility) const; - /// printOffset - This is just convenient handler for printing offsets. void printOffset(int64_t Offset) const; private: - void EmitLinkage(unsigned Linkage, MCSymbol *GVSym); + /// EmitVisibility - This emits visibility information about symbol, if + /// this is suported by the target. + void EmitVisibility(MCSymbol *Sym, unsigned Visibility) const; + + void EmitLinkage(unsigned Linkage, MCSymbol *GVSym) const; void EmitJumpTableEntry(const MachineJumpTableInfo *MJTI, const MachineBasicBlock *MBB, diff --git a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp index fd29937eb0b..2e61a6f655f 100644 --- a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp +++ b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp @@ -150,7 +150,7 @@ bool AsmPrinter::doInitialization(Module &M) { return false; } -void AsmPrinter::EmitLinkage(unsigned Linkage, MCSymbol *GVSym) { +void AsmPrinter::EmitLinkage(unsigned Linkage, MCSymbol *GVSym) const { switch ((GlobalValue::LinkageTypes)Linkage) { case GlobalValue::CommonLinkage: case GlobalValue::LinkOnceAnyLinkage: @@ -206,7 +206,7 @@ void AsmPrinter::EmitGlobalVariable(const GlobalVariable *GV) { return; MCSymbol *GVSym = GetGlobalValueSymbol(GV); - printVisibility(GVSym, GV->getVisibility()); + EmitVisibility(GVSym, GV->getVisibility()); if (MAI->hasDotTypeDotSizeDirective()) OutStreamer.EmitSymbolAttribute(GVSym, MCSA_ELF_TypeObject); @@ -300,7 +300,7 @@ void AsmPrinter::EmitFunctionHeader() { const Function *F = MF->getFunction(); OutStreamer.SwitchSection(getObjFileLowering().SectionForGlobal(F, Mang, TM)); - printVisibility(CurrentFnSym, F->getVisibility()); + EmitVisibility(CurrentFnSym, F->getVisibility()); EmitLinkage(F->getLinkage(), CurrentFnSym); EmitAlignment(MF->getAlignment(), F); @@ -384,7 +384,7 @@ bool AsmPrinter::doFinalization(Module &M) { else assert(I->hasLocalLinkage() && "Invalid alias linkage"); - printVisibility(Name, I->getVisibility()); + EmitVisibility(Name, I->getVisibility()); // Emit the directives as assignments aka .set: OutStreamer.EmitAssignment(Name, @@ -1605,8 +1605,7 @@ void AsmPrinter::EmitBasicBlockStart(const MachineBasicBlock *MBB) const { } } -void AsmPrinter::printVisibility(MCSymbol *Sym, unsigned Visibility) const { - // FIXME: RENAME TO EmitVisibility. +void AsmPrinter::EmitVisibility(MCSymbol *Sym, unsigned Visibility) const { MCSymbolAttr Attr = MCSA_Invalid; switch (Visibility) {