6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-07 12:28:24 +00:00
Code Issues Projects Releases Wiki Activity

COFF: fix an off by one error

Browse Source 
Adjust the tests to validate the number of auxiliary entries used to store the
filename.

Thanks to majnemer's sharp eye for catching the missing - 1 in the round up
calculation.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206359 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Saleem Abdulrasool
2014-04-16 06:22:53 +00:00
parent 5422dfb5b0
commit c09746dc9c
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/MC/WinCOFFObjectWriter.cpp
View File

@@ -638,7 +638,7 @@ void WinCOFFObjectWriter::ExecutePostLayoutBinding(MCAssembler &Asm,
for (auto FI = Asm.file_names_begin(), FE = Asm.file_names_end(); for (auto FI = Asm.file_names_begin(), FE = Asm.file_names_end();
FI != FE; ++FI) { FI != FE; ++FI) {
// round up to calculate the number of auxiliary symbols required // round up to calculate the number of auxiliary symbols required
unsigned Count = (FI->size() + COFF::SymbolSize) / COFF::SymbolSize; unsigned Count = (FI->size() + COFF::SymbolSize - 1) / COFF::SymbolSize;
COFFSymbol *file = createSymbol(".file"); COFFSymbol *file = createSymbol(".file");
file->Data.StorageClass = COFF::IMAGE_SYM_CLASS_FILE; file->Data.StorageClass = COFF::IMAGE_SYM_CLASS_FILE;

6
test/MC/COFF/file.s
View File

@@ -2,16 +2,16 @@
// RUN: | FileCheck %s -check-prefix CHECK-PRINT // RUN: | FileCheck %s -check-prefix CHECK-PRINT
.file "null-padded.asm" .file "null-padded.asm"
// CHECK-PRINT: .file // CHECK-PRINT: (nx 1) {{0x[0-9]+}} .file
// CHECK-PRINT-NEXT: AUX null-padded.asm{{$}} // CHECK-PRINT-NEXT: AUX null-padded.asm{{$}}
.file "eighteen-chars.asm" .file "eighteen-chars.asm"
// CHECK-PRINT: .file // CHECK-PRINT: (nx 1) {{0x[0-9]+}} .file
// CHECK-PRINT-NEXT: AUX eighteen-chars.asm{{$}} // CHECK-PRINT-NEXT: AUX eighteen-chars.asm{{$}}
.file "multiple-auxiliary-entries.asm" .file "multiple-auxiliary-entries.asm"
// CHECK-PRINT: .file // CHECK-PRINT: (nx 2) {{0x[0-9]+}} .file
// CHECK-PRINT-NEXT: AUX multiple-auxiliary-entries.asm{{$}} // CHECK-PRINT-NEXT: AUX multiple-auxiliary-entries.asm{{$}}