6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-11 10:25:41 +00:00
Code Issues Projects Releases Wiki Activity

Disable tail duplication in any "hard" cases, where it might break SSA form.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@11052 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner
2004-02-01 06:32:28 +00:00
parent d4baf0f74c
commit c23396e8de
1 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
lib/Transforms/Scalar/TailDuplication.cpp
View File

@@ -41,6 +41,7 @@ namespace {
bool runOnFunction(Function &F); bool runOnFunction(Function &F);
private: private:
inline bool shouldEliminateUnconditionalBranch(TerminatorInst *TI); inline bool shouldEliminateUnconditionalBranch(TerminatorInst *TI);
inline bool canEliminateUnconditionalBranch(TerminatorInst *TI);
inline void eliminateUnconditionalBranch(BranchInst *BI); inline void eliminateUnconditionalBranch(BranchInst *BI);
inline void InsertPHINodesIfNecessary(Instruction *OrigInst, Value *NewInst, inline void InsertPHINodesIfNecessary(Instruction *OrigInst, Value *NewInst,
BasicBlock *NewBlock); BasicBlock *NewBlock);
@@ -63,7 +64,8 @@ Pass *llvm::createTailDuplicationPass() { return new TailDup(); }
bool TailDup::runOnFunction(Function &F) { bool TailDup::runOnFunction(Function &F) {
bool Changed = false; bool Changed = false;
for (Function::iterator I = F.begin(), E = F.end(); I != E; ) for (Function::iterator I = F.begin(), E = F.end(); I != E; )
if (shouldEliminateUnconditionalBranch(I->getTerminator())) { if (shouldEliminateUnconditionalBranch(I->getTerminator()) &&
canEliminateUnconditionalBranch(I->getTerminator())) {
eliminateUnconditionalBranch(cast<BranchInst>(I->getTerminator())); eliminateUnconditionalBranch(cast<BranchInst>(I->getTerminator()));
Changed = true; Changed = true;
} else { } else {
@@ -111,6 +113,30 @@ bool TailDup::shouldEliminateUnconditionalBranch(TerminatorInst *TI) {
return true; return true;
} }
/// canEliminateUnconditionalBranch - Unfortunately, the general form of tail
/// duplication can do very bad things to SSA form, by destroying arbitrary
/// relationships between dominators and dominator frontiers as it processes the
/// program. The right solution for this is to have an incrementally updating
/// dominator data structure, which can gracefully react to arbitrary
/// "addEdge/removeEdge" changes to the CFG. Implementing this is nontrivial,
/// however, so we just disable the transformation in cases where it is not
/// currently safe.
///
bool TailDup::canEliminateUnconditionalBranch(TerminatorInst *TI) {
// Basically, we refuse to make the transformation if any of the values
// computed in the 'tail' are used in any other basic blocks.
BasicBlock *Tail = TI->getSuccessor(0);
for (BasicBlock::iterator I = Tail->begin(), E = Tail->end(); I != E; ++I)
for (Value::use_iterator UI = I->use_begin(), E = I->use_end(); UI != E;
++UI) {
Instruction *User = cast<Instruction>(*UI);
if (User->getParent() != Tail || isa<PHINode>(User))
return false;
}
return true;
}
/// eliminateUnconditionalBranch - Clone the instructions from the destination /// eliminateUnconditionalBranch - Clone the instructions from the destination
/// block into the source block, eliminating the specified unconditional branch. /// block into the source block, eliminating the specified unconditional branch.