From c2b94805fbaf0562f51d9fb682f0ec9b077706a6 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 21 Mar 2005 08:43:32 +0000 Subject: [PATCH] 'note to self' git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@20727 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/DataStructure/TopDownClosure.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/Analysis/DataStructure/TopDownClosure.cpp b/lib/Analysis/DataStructure/TopDownClosure.cpp index 26f259e649e..76f8244d077 100644 --- a/lib/Analysis/DataStructure/TopDownClosure.cpp +++ b/lib/Analysis/DataStructure/TopDownClosure.cpp @@ -188,8 +188,11 @@ void TDDataStructures::InlineCallersIntoGraph(DSGraph &DSG) { std::sort(EdgesFromCaller.begin(), EdgesFromCaller.end()); - // Merge information from the globals graph into this graph. - // FIXME: is this necessary? + // Merge information from the globals graph into this graph. FIXME: This is + // stupid. Instead of us cloning information from the GG into this graph, + // then having RemoveDeadNodes clone it back, we should do all of this as a + // post-pass over all of the graphs. We need to take cloning out of + // removeDeadNodes and gut removeDeadNodes at the same time first though. :( { DSGraph &GG = *DSG.getGlobalsGraph(); ReachabilityCloner RC(DSG, GG,