diff --git a/lib/Linker/LinkModules.cpp b/lib/Linker/LinkModules.cpp index 33acbb4afb2..55023b82bf9 100644 --- a/lib/Linker/LinkModules.cpp +++ b/lib/Linker/LinkModules.cpp @@ -294,12 +294,20 @@ static bool LinkMethodBodies(Module *Dest, const Module *Src, // Loop over all of the methods in the src module, mapping them over as we go // for (Module::const_iterator I = Src->begin(), E = Src->end(); I != E; ++I) { - const Method *SM = *I; // Source Method - Method *DM = cast(ValueMap[SM]); // Destination method + const Method *SM = *I; // Source Method + if (!SM->isExternal()) { // No body if method is external + Method *DM = cast(ValueMap[SM]); // Destination method + + // DM not external SM external? + if (!DM->isExternal()) { + if (Err) + *Err = "Method '" + (SM->hasName() ? SM->getName() : string("")) + + "' body multiply defined!"; + return true; + } - assert(DM && DM->isExternal() && "LinkMethodProtos failed!"); - if (!SM->isExternal()) // External methods are already done if (LinkMethodBody(DM, SM, ValueMap, Err)) return true; + } } return false; } diff --git a/lib/Transforms/Utils/Linker.cpp b/lib/Transforms/Utils/Linker.cpp index 33acbb4afb2..55023b82bf9 100644 --- a/lib/Transforms/Utils/Linker.cpp +++ b/lib/Transforms/Utils/Linker.cpp @@ -294,12 +294,20 @@ static bool LinkMethodBodies(Module *Dest, const Module *Src, // Loop over all of the methods in the src module, mapping them over as we go // for (Module::const_iterator I = Src->begin(), E = Src->end(); I != E; ++I) { - const Method *SM = *I; // Source Method - Method *DM = cast(ValueMap[SM]); // Destination method + const Method *SM = *I; // Source Method + if (!SM->isExternal()) { // No body if method is external + Method *DM = cast(ValueMap[SM]); // Destination method + + // DM not external SM external? + if (!DM->isExternal()) { + if (Err) + *Err = "Method '" + (SM->hasName() ? SM->getName() : string("")) + + "' body multiply defined!"; + return true; + } - assert(DM && DM->isExternal() && "LinkMethodProtos failed!"); - if (!SM->isExternal()) // External methods are already done if (LinkMethodBody(DM, SM, ValueMap, Err)) return true; + } } return false; } diff --git a/lib/VMCore/Linker.cpp b/lib/VMCore/Linker.cpp index 33acbb4afb2..55023b82bf9 100644 --- a/lib/VMCore/Linker.cpp +++ b/lib/VMCore/Linker.cpp @@ -294,12 +294,20 @@ static bool LinkMethodBodies(Module *Dest, const Module *Src, // Loop over all of the methods in the src module, mapping them over as we go // for (Module::const_iterator I = Src->begin(), E = Src->end(); I != E; ++I) { - const Method *SM = *I; // Source Method - Method *DM = cast(ValueMap[SM]); // Destination method + const Method *SM = *I; // Source Method + if (!SM->isExternal()) { // No body if method is external + Method *DM = cast(ValueMap[SM]); // Destination method + + // DM not external SM external? + if (!DM->isExternal()) { + if (Err) + *Err = "Method '" + (SM->hasName() ? SM->getName() : string("")) + + "' body multiply defined!"; + return true; + } - assert(DM && DM->isExternal() && "LinkMethodProtos failed!"); - if (!SM->isExternal()) // External methods are already done if (LinkMethodBody(DM, SM, ValueMap, Err)) return true; + } } return false; }