6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-13 20:32:21 +00:00
Code Issues Projects Releases Wiki Activity

[CMake] Don't pass in MSVC warning flags as definitions.

Browse Source 
NFC currently but required as a prerequisite for using
the Microsoft resource compiler in conjunction with
CMake's ninja generator, which knows how to filter flags
appropriately, but not definitions.

Differential Revision: http://reviews.llvm.org/D8188

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@232727 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Greg Bedwell 2015-03-19 16:32:47 +00:00
parent 8b4c9e18bb
commit c6e489793c
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
cmake/modules/HandleLLVMOptions.cmake
View File

@ -253,7 +253,9 @@ if( MSVC )
-D_CRT_NONSTDC_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS
-D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE
-D_SCL_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS
)
set(msvc_warning_flags
# Disabled warnings. # Disabled warnings.
-wd4146 # Suppress 'unary minus operator applied to unsigned type, result still unsigned' -wd4146 # Suppress 'unary minus operator applied to unsigned type, result still unsigned'
-wd4180 # Suppress 'qualifier applied to function type has no meaning; ignored' -wd4180 # Suppress 'qualifier applied to function type has no meaning; ignored'
@ -282,14 +284,19 @@ if( MSVC )
# Enable warnings # Enable warnings
if (LLVM_ENABLE_WARNINGS) if (LLVM_ENABLE_WARNINGS)
add_llvm_definitions( /W4 ) append("/W4" msvc_warning_flags)
if (LLVM_ENABLE_PEDANTIC) if (LLVM_ENABLE_PEDANTIC)
# No MSVC equivalent available # No MSVC equivalent available
endif (LLVM_ENABLE_PEDANTIC) endif (LLVM_ENABLE_PEDANTIC)
endif (LLVM_ENABLE_WARNINGS) endif (LLVM_ENABLE_WARNINGS)
if (LLVM_ENABLE_WERROR) if (LLVM_ENABLE_WERROR)
add_llvm_definitions( /WX ) append("/WX" msvc_warning_flags)
endif (LLVM_ENABLE_WERROR) endif (LLVM_ENABLE_WERROR)
foreach(flag ${msvc_warning_flags})
append("${flag}" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
endforeach(flag)
elseif( LLVM_COMPILER_IS_GCC_COMPATIBLE ) elseif( LLVM_COMPILER_IS_GCC_COMPATIBLE )
if (LLVM_ENABLE_WARNINGS) if (LLVM_ENABLE_WARNINGS)
append("-Wall -W -Wno-unused-parameter -Wwrite-strings" CMAKE_C_FLAGS CMAKE_CXX_FLAGS) append("-Wall -W -Wno-unused-parameter -Wwrite-strings" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)