6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-07-05 09:24:28 +00:00
Code Issues Projects Releases Wiki Activity

Add assertions to CastInst::getCastOpcode to catch attempted conversions

Browse Source 
between integers and pointers when the source type is marked signed,
since inttoptr and ptrtoint always use zero-extension when the destination
is larger than the source.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@72025 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Dan Gohman
2009-05-18 18:18:57 +00:00
parent 15ffc08267
commit c7897e26a4
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/VMCore/Instructions.cpp
View File

@ -2220,6 +2220,8 @@ CastInst::getCastOpcode(
} else { } else {
assert(isa<PointerType>(SrcTy) && assert(isa<PointerType>(SrcTy) &&
"Casting from a value that is not first-class type"); "Casting from a value that is not first-class type");
assert(!SrcIsSigned &&
"Pointer types cannot be considered signed for conversions!");
return PtrToInt; // ptr -> int return PtrToInt; // ptr -> int
} }
} else if (DestTy->isFloatingPoint()) { // Casting to floating pt } else if (DestTy->isFloatingPoint()) { // Casting to floating pt
@ -2259,6 +2261,7 @@ CastInst::getCastOpcode(
if (isa<PointerType>(SrcTy)) { if (isa<PointerType>(SrcTy)) {
return BitCast; // ptr -> ptr return BitCast; // ptr -> ptr
} else if (SrcTy->isInteger()) { } else if (SrcTy->isInteger()) {
assert(!SrcIsSigned && "Cannot cast signed integer to pointer!");
return IntToPtr; // int -> ptr return IntToPtr; // int -> ptr
} else { } else {
assert(!"Casting pointer to other than pointer or int"); assert(!"Casting pointer to other than pointer or int");