6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-03-24 07:35:04 +00:00
Code Issues Projects Releases Wiki Activity

DebugInfo: Prefer references over pointers, pass by const reference for a type that will grow in the future

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@188422 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Blaikie 2013-08-14 22:23:05 +00:00
parent 67ca7b1bb0
commit cbb5c73942
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/CodeGen/AsmPrinter/DIEHash.cpp
View File

@ -103,13 +103,13 @@ void DIEHash::addParentContext(DIE *Parent) {
}
// Collect all of the attributes for a particular DIE in single structure.
void DIEHash::collectAttributes(DIE *Die, DIEAttrs *Attrs) {
void DIEHash::collectAttributes(DIE *Die, DIEAttrs &Attrs) {
const SmallVectorImpl<DIEValue *> &Values = Die->getValues();
const DIEAbbrev &Abbrevs = Die->getAbbrev();
#define COLLECT_ATTR(NAME) \
Attrs->NAME.Val = Values[i]; \
Attrs->NAME.Desc = &Abbrevs.getData()[i];
Attrs.NAME.Val = Values[i]; \
Attrs.NAME.Desc = &Abbrevs.getData()[i];
for (size_t i = 0, e = Values.size(); i != e; ++i) {
DEBUG(dbgs() << "Attribute: "
@ -150,7 +150,7 @@ void DIEHash::hashAttribute(AttrEntry Attr) {
// Go through the attributes from \param Attrs in the order specified in 7.27.4
// and hash them.
void DIEHash::hashAttributes(DIEAttrs Attrs) {
void DIEHash::hashAttributes(const DIEAttrs &Attrs) {
#define ADD_ATTR(ATTR) \
{ \
if (ATTR.Val != 0) \
@ -165,7 +165,7 @@ void DIEHash::hashAttributes(DIEAttrs Attrs) {
void DIEHash::addAttributes(DIE *Die) {
DIEAttrs Attrs;
memset(&Attrs, 0, sizeof(Attrs));
collectAttributes(Die, &Attrs);
collectAttributes(Die, Attrs);
hashAttributes(Attrs);
}

4
lib/CodeGen/AsmPrinter/DIEHash.h
View File

@ -59,10 +59,10 @@ private:
/// \brief Collects the attributes of DIE \param Die into the \param Attrs
/// structure.
void collectAttributes(DIE *Die, DIEAttrs *Attrs);
void collectAttributes(DIE *Die, DIEAttrs &Attrs);
/// \brief Hashes the attributes in \param Attrs in order.
void hashAttributes(DIEAttrs Attrs);
void hashAttributes(const DIEAttrs &Attrs);
/// \brief Hashes an individual attribute.
void hashAttribute(AttrEntry Attr);