sink clone() down the class hierarchy from CmpInst into ICmpInst/FCmpInst.

This eliminates a conditional on that path, and ensures ICmpInst/FCmpInst
both have an out-of-line virtual method to home the class.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@41371 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2007-08-24 20:48:18 +00:00
parent 7097e9a710
commit cd406fe123
3 changed files with 9 additions and 5 deletions

View File

@ -494,9 +494,6 @@ public:
Value *S2, const std::string &Name,
BasicBlock *InsertAtEnd);
/// @brief Implement superclass method.
virtual CmpInst *clone() const;
/// @brief Get the opcode casted to the right type
OtherOps getOpcode() const {
return static_cast<OtherOps>(Instruction::getOpcode());

View File

@ -603,6 +603,8 @@ public:
std::swap(Ops[0], Ops[1]);
}
virtual ICmpInst *clone() const;
// Methods for support type inquiry through isa, cast, and dyn_cast:
static inline bool classof(const ICmpInst *) { return true; }
static inline bool classof(const Instruction *I) {
@ -725,6 +727,8 @@ public:
std::swap(Ops[0], Ops[1]);
}
virtual FCmpInst *clone() const;
/// @brief Methods for support type inquiry through isa, cast, and dyn_cast:
static inline bool classof(const FCmpInst *) { return true; }
static inline bool classof(const Instruction *I) {

View File

@ -2595,8 +2595,11 @@ BinaryOperator *BinaryOperator::clone() const {
return create(getOpcode(), Ops[0], Ops[1]);
}
CmpInst* CmpInst::clone() const {
return create(getOpcode(), getPredicate(), Ops[0], Ops[1]);
FCmpInst* FCmpInst::clone() const {
return new FCmpInst(getPredicate(), Ops[0], Ops[1]);
}
ICmpInst* ICmpInst::clone() const {
return new ICmpInst(getPredicate(), Ops[0], Ops[1]);
}
MallocInst *MallocInst::clone() const { return new MallocInst(*this); }