From ce986b6bc0f5119d9fdf928cc8ab80e5e6bd165f Mon Sep 17 00:00:00 2001 From: Filipe Cabecinhas Date: Sat, 6 Jun 2015 20:44:53 +0000 Subject: [PATCH] Use early return idiom. NFC git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@239228 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Bitcode/Reader/BitcodeReader.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/Bitcode/Reader/BitcodeReader.cpp b/lib/Bitcode/Reader/BitcodeReader.cpp index 75b3b9fd73c..056d87beef1 100644 --- a/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/lib/Bitcode/Reader/BitcodeReader.cpp @@ -2065,13 +2065,13 @@ std::error_code BitcodeReader::ResolveGlobalAndAliasInits() { if (ValID >= ValueList.size()) { AliasInits.push_back(AliasInitWorklist.back()); } else { - if (Constant *C = dyn_cast_or_null(ValueList[ValID])) { - GlobalAlias *Alias = AliasInitWorklist.back().first; - if (C->getType() != Alias->getType()) - return Error("Alias and aliasee types don't match"); - Alias->setAliasee(C); - } else + Constant *C = dyn_cast_or_null(ValueList[ValID]); + if (!C) return Error("Expected a constant"); + GlobalAlias *Alias = AliasInitWorklist.back().first; + if (C->getType() != Alias->getType()) + return Error("Alias and aliasee types don't match"); + Alias->setAliasee(C); } AliasInitWorklist.pop_back(); }