Revert r111394. It was too aggressive.

We must complete the DFS, otherwise we might miss needed phi-defs, and
prematurely color live ranges with a non-dominating value.

This is not a big deal since we get to color more of the CFG and the next
mapValue call will be faster.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@111397 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Jakob Stoklund Olesen
2010-08-18 20:06:05 +00:00
parent 4d440bd786
commit cf16bea74e
2 changed files with 3 additions and 12 deletions
+3 -3
View File
@@ -446,9 +446,9 @@ VNInfo *LiveIntervalMap::mapValue(const VNInfo *ParentVNI, SlotIndex Idx) {
}
// No need to search the children, we found a dominating value.
// MBB is either the found dominating value, or the last phi-def we created.
// Either way, the children of MBB would be shadowed, so don't search them.
IDFI.skipChildren(MBB);
// FIXME: We could prune up to the last phi-def we inserted, need df_iterator
// for that.
IDFI.skipChildren();
}
// The search should at least find a dominating value for IdxMBB.