6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-02-18 14:31:27 +00:00
Code Issues Projects Releases Wiki Activity

Rewrite assert to avoid warning when the record element type is byte-sized.

Browse Source 
BitstreamWriter asserts that when blob data is written from the record
element vector, each element fits in a byte. However, if the record
elements are specified as a SmallVector of 'char', this causes a warning
from -Wtautological-constant-out-of-range-compare. Fix this by using
llvm::isUInt<8> instead of a plain comparison against 256.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@181545 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Jordan Rose 2013-05-09 21:07:43 +00:00
parent edfef3bd27
commit d044f65e37
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/llvm/Bitcode/BitstreamWriter.h
View File

@ -381,7 +381,8 @@ private:
BlobData = 0; BlobData = 0;
} else { } else {
for (unsigned e = Vals.size(); RecordIdx != e; ++RecordIdx) { for (unsigned e = Vals.size(); RecordIdx != e; ++RecordIdx) {
assert(Vals[RecordIdx] < 256 && "Value too large to emit as blob"); assert(isUInt<8>(Vals[RecordIdx]) &&
"Value too large to emit as blob");
WriteByte((unsigned char)Vals[RecordIdx]); WriteByte((unsigned char)Vals[RecordIdx]);
} }
} }