6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-04-11 00:39:36 +00:00
Code Issues Projects Releases Wiki Activity

In Release modes, Visual Studio complains that the Operator destructor in User.cpp

Browse Source 
never returns, which is true by design. 

Initially assumed that the reason is llvm_unreachable being dependent on NDEBUG.

However, even if llvm_unreachable is replaced by __assume(false), VC still warns in
Release modes but not in Debug modes...

The real reason turned out to be optimization flags.
With /Od in Debug modes the warning is not issued whereas with /O1 it is.

I could not find any documentation to this effect, but it is reproducable:

Try compiling http://msdn.microsoft.com/en-us/library/khwfyc5d(v=vs.90).aspx
with /O1 and then with /Od.




git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204659 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Yaron Keren 2014-03-24 19:48:13 +00:00
parent 6c199d8212
commit d816eda3c7
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
lib/IR/User.cpp
View File

@ -83,8 +83,28 @@ void User::operator delete(void *Usr) {
// Operator Class
//===----------------------------------------------------------------------===//
#if defined(_MSC_VER)
// In Release modes, Visual Studio complains that the Operator destructor
// never returns, which is true by design.
// This does *not* depend on llvm_unreachable being dependent on NDEBUG:
// even if llvm_unreachable is replaced by __assume(false), VC still warns in
// Release modes but not in Debug modes. The real reason is optimization flags.
// With /Od in Debug modes the warning is not issued whereas with /O1 it is.
// I could not find any documentation to this effect, it is reproducable:
// Try compiling http://msdn.microsoft.com/en-us/library/khwfyc5d(v=vs.90).aspx
// with /O1 and then with /Od.
// Anyhow, solution is same as lib/Support/Process.cpp:~self_process().
#pragma warning(push)
#pragma warning(disable:4722)
#endif
Operator::~Operator() {
llvm_unreachable("should never destroy an Operator");
}
#if defined(_MSC_VER)
#pragma warning(pop)
#endif
} // End llvm namespace