6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-22 10:24:26 +00:00
Code Issues Projects Releases Wiki Activity

Simplify getSymbolFlags.

Browse Source 
None of the object formats require extra parsing to compute these flags,
so the method cannot fail.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200574 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Rafael Espindola
2014-01-31 20:57:12 +00:00
parent c2c98e7884
commit d8324e6983
10 changed files with 22 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
include/llvm/Object/COFF.h
View File

@ -279,8 +279,7 @@ protected:
error_code getSymbolFileOffset(DataRefImpl Symb, uint64_t &Res) const
LLVM_OVERRIDE;
error_code getSymbolSize(DataRefImpl Symb, uint64_t &Res) const LLVM_OVERRIDE;
error_code getSymbolFlags(DataRefImpl Symb, uint32_t &Res) const
LLVM_OVERRIDE;
uint32_t getSymbolFlags(DataRefImpl Symb) const LLVM_OVERRIDE;
error_code getSymbolType(DataRefImpl Symb, SymbolRef::Type &Res) const
LLVM_OVERRIDE;
error_code getSymbolSection(DataRefImpl Symb, section_iterator &Res) const

9
include/llvm/Object/ELFObjectFile.h
View File

@ -65,7 +65,7 @@ protected:
error_code getSymbolAlignment(DataRefImpl Symb, uint32_t &Res) const
LLVM_OVERRIDE;
error_code getSymbolSize(DataRefImpl Symb, uint64_t &Res) const LLVM_OVERRIDE;
error_code getSymbolFlags(DataRefImpl Symb, uint32_t &Res) const;
uint32_t getSymbolFlags(DataRefImpl Symb) const LLVM_OVERRIDE;
error_code getSymbolType(DataRefImpl Symb, SymbolRef::Type &Res) const
LLVM_OVERRIDE;
error_code getSymbolSection(DataRefImpl Symb, section_iterator &Res) const
@ -378,11 +378,10 @@ error_code ELFObjectFile<ELFT>::getSymbolType(DataRefImpl Symb,
}
template <class ELFT>
error_code ELFObjectFile<ELFT>::getSymbolFlags(DataRefImpl Symb,
uint32_t &Result) const {
uint32_t ELFObjectFile<ELFT>::getSymbolFlags(DataRefImpl Symb) const {
const Elf_Sym *ESym = getSymbol(Symb);
Result = SymbolRef::SF_None;
uint32_t Result = SymbolRef::SF_None;
if (ESym->getBinding() != ELF::STB_LOCAL)
Result |= SymbolRef::SF_Global;
@ -407,7 +406,7 @@ error_code ELFObjectFile<ELFT>::getSymbolFlags(DataRefImpl Symb,
if (ESym->getType() == ELF::STT_TLS)
Result |= SymbolRef::SF_ThreadLocal;
return object_error::success;
return Result;
}
template <class ELFT>

3
include/llvm/Object/MachO.h
View File

@ -71,8 +71,7 @@ public:
error_code getSymbolSize(DataRefImpl Symb, uint64_t &Res) const LLVM_OVERRIDE;
error_code getSymbolType(DataRefImpl Symb, SymbolRef::Type &Res) const
LLVM_OVERRIDE;
error_code getSymbolFlags(DataRefImpl Symb, uint32_t &Res) const
LLVM_OVERRIDE;
uint32_t getSymbolFlags(DataRefImpl Symb) const LLVM_OVERRIDE;
error_code getSymbolSection(DataRefImpl Symb, section_iterator &Res) const
LLVM_OVERRIDE;
error_code getSymbolValue(DataRefImpl Symb, uint64_t &Val) const

9
include/llvm/Object/ObjectFile.h
View File

@ -219,7 +219,7 @@ public:
error_code getType(SymbolRef::Type &Result) const;
/// Get symbol flags (bitwise OR of SymbolRef::Flags)
error_code getFlags(uint32_t &Result) const;
uint32_t getFlags() const;
/// @brief Get section this symbol is defined in reference to. Result is
/// end_sections() if it is undefined or is an absolute symbol.
@ -289,8 +289,7 @@ protected:
virtual error_code getSymbolSize(DataRefImpl Symb, uint64_t &Res) const = 0;
virtual error_code getSymbolType(DataRefImpl Symb,
SymbolRef::Type &Res) const = 0;
virtual error_code getSymbolFlags(DataRefImpl Symb,
uint32_t &Res) const = 0;
virtual uint32_t getSymbolFlags(DataRefImpl Symb) const = 0;
virtual error_code getSymbolSection(DataRefImpl Symb,
section_iterator &Res) const = 0;
virtual error_code getSymbolValue(DataRefImpl Symb, uint64_t &Val) const = 0;
@ -428,8 +427,8 @@ inline error_code SymbolRef::getSize(uint64_t &Result) const {
return OwningObject->getSymbolSize(SymbolPimpl, Result);
}
inline error_code SymbolRef::getFlags(uint32_t &Result) const {
return OwningObject->getSymbolFlags(SymbolPimpl, Result);
inline uint32_t SymbolRef::getFlags() const {
return OwningObject->getSymbolFlags(SymbolPimpl);
}
inline error_code SymbolRef::getSection(section_iterator &Result) const {