From d9723e9a2800e3f74652ef3be7c1c2c58d01f376 Mon Sep 17 00:00:00 2001 From: Devang Patel Date: Tue, 20 Oct 2009 22:50:27 +0000 Subject: [PATCH] Cosmetic changes. s/validName/isValidName/g s/with an Instruction/to an Instruction/g s/RegisterMDKind/registerMDKind/g git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@84689 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Metadata.h | 14 +++++++------- include/llvm/Support/IRBuilder.h | 2 +- lib/AsmParser/LLParser.cpp | 2 +- lib/VMCore/Metadata.cpp | 18 +++++++++--------- 4 files changed, 18 insertions(+), 18 deletions(-) diff --git a/include/llvm/Metadata.h b/include/llvm/Metadata.h index 4a595b5b713..388361efc2b 100644 --- a/include/llvm/Metadata.h +++ b/include/llvm/Metadata.h @@ -295,25 +295,25 @@ private: StringMap MDHandlerNames; public: - /// RegisterMDKind - Register a new metadata kind and return its ID. + /// registerMDKind - Register a new metadata kind and return its ID. /// A metadata kind can be registered only once. - unsigned RegisterMDKind(const char *Name); + unsigned registerMDKind(const char *Name); /// getMDKind - Return metadata kind. If the requested metadata kind /// is not registered then return 0. unsigned getMDKind(const char *Name); - /// validName - Return true if Name is a valid custom metadata handler name. - bool validName(const char *Name); + /// isValidName - Return true if Name is a valid custom metadata handler name. + bool isValidName(const char *Name); - /// getMD - Get the metadata of given kind attached with an Instruction. + /// getMD - Get the metadata of given kind attached to an Instruction. /// If the metadata is not found then return 0. MDNode *getMD(unsigned Kind, const Instruction *Inst); - /// getMDs - Get the metadata attached with an Instruction. + /// getMDs - Get the metadata attached to an Instruction. const MDMapTy *getMDs(const Instruction *Inst); - /// addMD - Attach the metadata of given kind with an Instruction. + /// addMD - Attach the metadata of given kind to an Instruction. void addMD(unsigned Kind, MDNode *Node, Instruction *Inst); /// removeMD - Remove metadata of given kind attached with an instuction. diff --git a/include/llvm/Support/IRBuilder.h b/include/llvm/Support/IRBuilder.h index f4d1101cdfa..83df9edc0c4 100644 --- a/include/llvm/Support/IRBuilder.h +++ b/include/llvm/Support/IRBuilder.h @@ -139,7 +139,7 @@ public: if (MDKind == 0) MDKind = Context.getMetadata().getMDKind("dbg"); if (MDKind == 0) - MDKind = Context.getMetadata().RegisterMDKind("dbg"); + MDKind = Context.getMetadata().registerMDKind("dbg"); CurDbgLocation = L; } diff --git a/lib/AsmParser/LLParser.cpp b/lib/AsmParser/LLParser.cpp index 0c1fce9f414..f1d5e4ffbb7 100644 --- a/lib/AsmParser/LLParser.cpp +++ b/lib/AsmParser/LLParser.cpp @@ -1067,7 +1067,7 @@ bool LLParser::ParseOptionalCustomMetadata() { MetadataContext &TheMetadata = M->getContext().getMetadata(); unsigned MDK = TheMetadata.getMDKind(Name.c_str()); if (!MDK) - MDK = TheMetadata.RegisterMDKind(Name.c_str()); + MDK = TheMetadata.registerMDKind(Name.c_str()); MDsOnInst.push_back(std::make_pair(MDK, cast(Node))); return false; diff --git a/lib/VMCore/Metadata.cpp b/lib/VMCore/Metadata.cpp index 0434c6dd2a1..eaefb4a3fd4 100644 --- a/lib/VMCore/Metadata.cpp +++ b/lib/VMCore/Metadata.cpp @@ -245,10 +245,10 @@ NamedMDNode::~NamedMDNode() { // MetadataContext implementation. // -/// RegisterMDKind - Register a new metadata kind and return its ID. +/// registerMDKind - Register a new metadata kind and return its ID. /// A metadata kind can be registered only once. -unsigned MetadataContext::RegisterMDKind(const char *Name) { - assert(validName(Name) && "Invalid custome metadata name!"); +unsigned MetadataContext::registerMDKind(const char *Name) { + assert(isValidName(Name) && "Invalid custome metadata name!"); unsigned Count = MDHandlerNames.size(); assert(MDHandlerNames.find(Name) == MDHandlerNames.end() && "Already registered MDKind!"); @@ -256,8 +256,8 @@ unsigned MetadataContext::RegisterMDKind(const char *Name) { return Count + 1; } -/// validName - Return true if Name is a valid custom metadata handler name. -bool MetadataContext::validName(const char *Name) { +/// isValidName - Return true if Name is a valid custom metadata handler name. +bool MetadataContext::isValidName(const char *Name) { if (!Name) return false; @@ -280,7 +280,7 @@ bool MetadataContext::validName(const char *Name) { /// getMDKind - Return metadata kind. If the requested metadata kind /// is not registered then return 0. unsigned MetadataContext::getMDKind(const char *Name) { - assert(validName(Name) && "Invalid custome metadata name!"); + assert(isValidName(Name) && "Invalid custome metadata name!"); StringMap::iterator I = MDHandlerNames.find(Name); if (I == MDHandlerNames.end()) return 0; @@ -288,7 +288,7 @@ unsigned MetadataContext::getMDKind(const char *Name) { return I->getValue(); } -/// addMD - Attach the metadata of given kind with an Instruction. +/// addMD - Attach the metadata of given kind to an Instruction. void MetadataContext::addMD(unsigned MDKind, MDNode *Node, Instruction *Inst) { assert(Node && "Invalid null MDNode"); Inst->HasMetadata = true; @@ -362,7 +362,7 @@ void MetadataContext::copyMD(Instruction *In1, Instruction *In2) { addMD(I->first, MD, In2); } -/// getMD - Get the metadata of given kind attached with an Instruction. +/// getMD - Get the metadata of given kind attached to an Instruction. /// If the metadata is not found then return 0. MDNode *MetadataContext::getMD(unsigned MDKind, const Instruction *Inst) { MDStoreTy::iterator I = MetadataStore.find(Inst); @@ -376,7 +376,7 @@ MDNode *MetadataContext::getMD(unsigned MDKind, const Instruction *Inst) { return NULL; } -/// getMDs - Get the metadata attached with an Instruction. +/// getMDs - Get the metadata attached to an Instruction. const MetadataContext::MDMapTy * MetadataContext::getMDs(const Instruction *Inst) { MDStoreTy::iterator I = MetadataStore.find(Inst);