diff --git a/include/llvm/Object/ELF.h b/include/llvm/Object/ELF.h index a84461020e3..4a5eebf0266 100644 --- a/include/llvm/Object/ELF.h +++ b/include/llvm/Object/ELF.h @@ -513,6 +513,8 @@ public: return Tmp; } + const char *get() const { return Current; } + private: const uint64_t EntitySize; const char *Current; @@ -2292,7 +2294,7 @@ library_iterator ELFObjectFile<ELFT>::begin_libraries_needed() const { } DataRefImpl DRI; - DRI.p = reinterpret_cast<uintptr_t>(&*i); + DRI.p = reinterpret_cast<uintptr_t>(i.get()); return library_iterator(LibraryRef(DRI, this)); } @@ -2312,7 +2314,7 @@ error_code ELFObjectFile<ELFT>::getLibraryNext(DataRefImpl Data, ; DataRefImpl DRI; - DRI.p = reinterpret_cast<uintptr_t>(&*i); + DRI.p = reinterpret_cast<uintptr_t>(i.get()); Result = LibraryRef(DRI, this); return object_error::success; } @@ -2343,7 +2345,7 @@ template<class ELFT> library_iterator ELFObjectFile<ELFT>::end_libraries_needed() const { dyn_iterator e = end_dynamic_table(); DataRefImpl DRI; - DRI.p = reinterpret_cast<uintptr_t>(&*e); + DRI.p = reinterpret_cast<uintptr_t>(e.get()); return library_iterator(LibraryRef(DRI, this)); } diff --git a/test/Object/readobj.test b/test/Object/readobj.test new file mode 100644 index 00000000000..e29f40492d7 --- /dev/null +++ b/test/Object/readobj.test @@ -0,0 +1,2 @@ +// Don't crash while reading non-dynamic files. +RUN: llvm-readobj %p/Inputs/trivial-object-test.elf-x86-64