From e250f2a5ee2a794e531b159c270b63f5e70dfc27 Mon Sep 17 00:00:00 2001 From: Eric Christopher Date: Fri, 21 Aug 2009 04:10:31 +0000 Subject: [PATCH] Update error messages for '+'. Fix grammar and make the two negative checks resemble each other. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@79595 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/APInt.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/Support/APInt.cpp b/lib/Support/APInt.cpp index 1754baed069..6943d279767 100644 --- a/lib/Support/APInt.cpp +++ b/lib/Support/APInt.cpp @@ -623,14 +623,15 @@ unsigned APInt::getBitsNeeded(const StringRef& str, uint8_t radix) { size_t slen = str.size(); - // Each computation below needs to know if its negative + // Each computation below needs to know if it's negative. StringRef::iterator p = str.begin(); - unsigned isNegative = str.front() == '-'; + unsigned isNegative = *p == '-'; if (*p == '-' || *p == '+') { p++; slen--; - assert(slen && "string is only a minus!"); + assert(slen && "String is only a sign, needs a value."); } + // For radixes of power-of-two values, the bits required is accurately and // easily computed if (radix == 2) @@ -2052,7 +2053,7 @@ void APInt::fromString(unsigned numbits, const StringRef& str, uint8_t radix) { if (*p == '-' || *p == '+') { p++; slen--; - assert(slen && "string is only a minus!"); + assert(slen && "String is only a sign, needs a value."); } assert((slen <= numbits || radix != 2) && "Insufficient bit width"); assert(((slen-1)*3 <= numbits || radix != 8) && "Insufficient bit width");