[MCJIT] Turn the getSymbolAddress free function created in r218626 into a static

member of RTDyldMemoryManager (and rename to getSymbolAddressInProcess).

The functionality this provides is very specific to RTDyldMemoryManager, so it
makes sense to keep it in that class to avoid accidental re-use.

No functional change.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218741 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Lang Hames
2014-10-01 04:11:13 +00:00
parent b69f873ee1
commit e2ef4419a8
3 changed files with 13 additions and 7 deletions

View File

@ -140,7 +140,8 @@ TEST_F(ExecutionEngineTest, LookupWithMangledName) {
// Demonstrate that getSymbolAddress accepts mangled names and always strips
// the leading underscore.
EXPECT_EQ(reinterpret_cast<uint64_t>(&x), getSymbolAddress("_x"));
EXPECT_EQ(reinterpret_cast<uint64_t>(&x),
RTDyldMemoryManager::getSymbolAddressInProcess("_x"));
}
TEST_F(ExecutionEngineTest, LookupWithMangledAndDemangledSymbol) {
@ -151,7 +152,8 @@ TEST_F(ExecutionEngineTest, LookupWithMangledAndDemangledSymbol) {
// Lookup the demangled name first, even if there's a demangled symbol that
// matches the input already.
EXPECT_EQ(reinterpret_cast<uint64_t>(&x), getSymbolAddress("_x"));
EXPECT_EQ(reinterpret_cast<uint64_t>(&x),
RTDyldMemoryManager::getSymbolAddressInProcess("_x"));
}
TEST_F(ExecutionEngineTest, LookupwithDemangledName) {
@ -159,7 +161,8 @@ TEST_F(ExecutionEngineTest, LookupwithDemangledName) {
llvm::sys::DynamicLibrary::AddSymbol("_x", &_x);
// But do fallback to looking up a demangled name if there's no ambiguity
EXPECT_EQ(reinterpret_cast<uint64_t>(&_x), getSymbolAddress("_x"));
EXPECT_EQ(reinterpret_cast<uint64_t>(&_x),
RTDyldMemoryManager::getSymbolAddressInProcess("_x"));
}
}