From e302b6cb69e96b948101e1ab6c0476187c92ee84 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Sat, 5 Jan 2013 21:39:33 +0000 Subject: [PATCH] Include access modifiers in subprogram metadata IR comment. Based on code review feedback in r171604 from Chandler Carruth & Eric Christopher. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@171636 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/IR/DebugInfo.cpp | 5 +++++ test/DebugInfo/2009-11-03-InsertExtractValue.ll | 14 +++++++++----- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/lib/IR/DebugInfo.cpp b/lib/IR/DebugInfo.cpp index bec941afda3..5dd9dd1c9d5 100644 --- a/lib/IR/DebugInfo.cpp +++ b/lib/IR/DebugInfo.cpp @@ -1122,6 +1122,11 @@ void DISubprogram::printInternal(raw_ostream &OS) const { if (getScopeLineNumber() != getLineNumber()) OS << " [scope " << getScopeLineNumber() << "]"; + if (isPrivate()) + OS << " [private]"; + else if (isProtected()) + OS << " [protected]"; + StringRef Res = getName(); if (!Res.empty()) OS << " [" << Res << ']'; diff --git a/test/DebugInfo/2009-11-03-InsertExtractValue.ll b/test/DebugInfo/2009-11-03-InsertExtractValue.ll index 8782e4446f4..933384af746 100644 --- a/test/DebugInfo/2009-11-03-InsertExtractValue.ll +++ b/test/DebugInfo/2009-11-03-InsertExtractValue.ll @@ -1,11 +1,15 @@ ; RUN: llvm-as < %s | llvm-dis | FileCheck %s -!0 = metadata !{i32 42} +!dbg = !{!0} +!0 = metadata !{i32 786478, i32 0, metadata !1, metadata !"bar", metadata !"bar", metadata !"_ZN3foo3barEv", metadata !1, i32 3, metadata !"nard", i1 false, i1 false, i32 0, i32 0, null, i32 258, i1 false, null, null, i32 0, metadata !1, i32 3} +!1 = metadata !{i32 42} define <{i32, i32}> @f1() { -; CHECK: !dbgx !0 - %r = insertvalue <{ i32, i32 }> zeroinitializer, i32 4, 1, !dbgx !0 -; CHECK: !dbgx !0 - %e = extractvalue <{ i32, i32 }> %r, 0, !dbgx !0 +; CHECK: !dbgx !1 + %r = insertvalue <{ i32, i32 }> zeroinitializer, i32 4, 1, !dbgx !1 +; CHECK: !dbgx !1 + %e = extractvalue <{ i32, i32 }> %r, 0, !dbgx !1 ret <{ i32, i32 }> %r } + +; CHECK: [protected]